[v4.6] Add tax_category_id method to Spree::Product#6427
Open
solidus-bot[bot] wants to merge 2 commits intov4.6from
Open
[v4.6] Add tax_category_id method to Spree::Product#6427solidus-bot[bot] wants to merge 2 commits intov4.6from
solidus-bot[bot] wants to merge 2 commits intov4.6from
Conversation
The method has some logic inside, but was never tested. Test that the correct tax_category or the default tax_category will be returned. (cherry picked from commit 7180bdc)
The LineItem and the Variant are referencing the tax_category_id, but does not have the same logic as the tax_category (the fallback to the default tax category). This method mirrors the same logic as the tax_category method. (cherry picked from commit fc8e4ee)
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.6 #6427 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 963 963
Lines 20213 20215 +2
=======================================
+ Hits 18065 18067 +2
Misses 2148 2148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.6:Questions ?
Please refer to the Backport tool documentation