Calculator spec: Fix Rubocop offenses#6289
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Jun 18, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6289 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 860 860
Lines 18423 18423
=======================================
Hits 16388 16388
Misses 2035 2035 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It's actually not great to define classes in tests.
1826cfa to
80fd096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves some classes to become anonymous classes. Fixes a Rubocop offense. Extracted from #6287
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: