fix: detect shared chunks via moduleIds and imported css instead of isDynamicEntry - #2275
Merged
Conversation
🦋 Changeset detectedLatest commit: 79c6f30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
Contributor
Author
|
P.S. @ryansolid, if this is being accepted, the same changes probably have to be applied in the Solid v2 manifest logic |
katywings
force-pushed
the
fix-vite8-shared-chunk-css
branch
from
August 1, 2026 20:07
dd1a6dc to
500b154
Compare
birkskyum
reviewed
Aug 1, 2026
birkskyum
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Shared chunk css hasn't been server rendered in production as of late, resulting in flashes of unstyled content. Probably caused by the upgrade to vite 8, shared chunks no longer are being flagged as dynamic entry, causing them to not be picked up by the shared chunk id remapping logic.
What is the new behavior?
Shared chunk css is being server rendered again in production. The remapping logic has being updated, to detect shared chunks based on quantity of included modules + imported css, instead of
isDynamicEntry.