Skip to content

fix: canvas raw shader access #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CosmaVergari wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix: canvas raw shader access #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/core/elementNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,7 +1620,11 @@ export class ElementNode {
}

// Can you put effects on Text nodes? Need to confirm...
if (SHADERS_ENABLED && props.shader && !props.shader.program) {
if (
SHADERS_ENABLED &&
props.shader &&
!('program' in props.shader || 'render' in props.shader) // If not a raw shader

@chiefcll chiefcll Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just look for render? Do we need both program and render?

@CosmaVergari CosmaVergari Jun 19, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that "render" is added in the Canvas shader node and "program" in the WebGL shader node, so we should check for the presence of any of the two

) {
props.shader = Config.convertToShader(node, props.shader);
}

Expand Down Expand Up @@ -1675,7 +1679,11 @@ export class ElementNode {
}
}

if (SHADERS_ENABLED && props.shader && !props.shader.program) {
if (
SHADERS_ENABLED &&
props.shader &&
!('program' in props.shader || 'render' in props.shader) // If not a raw shader
) {
props.shader = Config.convertToShader(node, props.shader);
}

Expand Down