Skip to content

fix(textures): adjust premultiplyAlpha handling for Safari 8 (movistar) compatibility#106

Open
pecoram wants to merge 1 commit into
solid-tv:mainfrom
pecoram:fix/premultiplyalpha-safari8
Open

fix(textures): adjust premultiplyAlpha handling for Safari 8 (movistar) compatibility#106
pecoram wants to merge 1 commit into
solid-tv:mainfrom
pecoram:fix/premultiplyalpha-safari8

Conversation

@pecoram

@pecoram pecoram commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@chiefcll

chiefcll commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

I'm fairly certain this is wrong.

Recommendation
Request changes. As written, this trades a movistar bug for a double-premultiply regression on every honored device, and leaves the producer (premultiplyAlpha = upload intent) and consumer (WebGlCtxTexture) contracts inconsistent. Preferred paths, in order:

Fix movistar via config (premultiplyAlphaHonored: false/'auto') with no source change

You should review this
#52

@pecoram

pecoram commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

I'm fairly certain this is wrong.

Recommendation Request changes. As written, this trades a movistar bug for a double-premultiply regression on every honored device, and leaves the producer (premultiplyAlpha = upload intent) and consumer (WebGlCtxTexture) contracts inconsistent. Preferred paths, in order:

Fix movistar via config (premultiplyAlphaHonored: false/'auto') with no source change

You should review this #52

Keep in mind that we've released it (with a patch) and haven't received any reports yet. We tested #52, and it didn't work as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants