Skip to content

refactor: Siteuser 도메인 리팩터링 #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whqtker merged 16 commits into from
Jun 24, 2025
Merged

refactor: Siteuser 도메인 리팩터링 #336

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
389ce9b
refactor: SiteUser 엔티티
whqtker May 29, 2025
0699152
fix: site_user 테이블의 nickname 컬럼에 unique 제약 조건 추가
whqtker May 29, 2025
e5a7cc2
refactor: SiteUser 도메인 관련
whqtker May 29, 2025
158a5f8
refactor: 회원 정보 변경 관련 로직 수정
whqtker May 29, 2025
6f7cf1f
refactor: sign up 시 닉네임 검증 로직 제거
whqtker Jun 12, 2025
c8115f3
refactor: 도메인 로직 변경에 따른 테스트 코드 수정
whqtker Jun 12, 2025
afdf86f
refactor: 예외 처리를 컨트롤러가 아닌 서비스 계층에서 처리하도록 변경
whqtker Jun 15, 2025
074ca56
refactor: JPQL이 아닌 dirty check를 사용하도록 변경 외
whqtker Jun 15, 2025
d455281
refactor: 로그에만 예외 원문 포함하도록 변경 및 상태코드 수정
whqtker Jun 15, 2025
c88c131
refactor: 회원가입 시 닉네임 관련 애플리케이션 레벨 검증 추가
whqtker Jun 15, 2025
484bcd3
refactor: 미사용 코드 제거 (JPQL 관련)
whqtker Jun 15, 2025
a2c81ab
test: 중복된_닉네임으로_사용자를_저장하면_예외_응답을_반환한다 테스트 수정
whqtker Jun 15, 2025
4f7f4f4
chore: 미사용 import문 제거
whqtker Jun 19, 2025
b4c9f98
chore: 함수명과 중괄호 사이 띄어쓰기 추가 (컨벤션 관련)
whqtker Jun 19, 2025
16e55f7
chore: 호출 순서에 따라 메서드 선언 재배치
whqtker Jun 19, 2025
6265684
chore: 마이그레이션 파일 버전 수정 V13 -> V14
whqtker Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/com/example/solidconnection/siteuser/repository/SiteUserRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@
import com.example.solidconnection.siteuser.domain.AuthType;
import com.example.solidconnection.siteuser.domain.SiteUser;
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.data.jpa.repository.Modifying;
Comment thread
nayonsoso marked this conversation as resolved.
Outdated
import org.springframework.data.jpa.repository.Query;
import org.springframework.data.repository.query.Param;
import org.springframework.stereotype.Repository;

import java.time.LocalDate;
import java.time.LocalDateTime;
import java.util.List;
import java.util.Optional;

Expand All @@ -22,4 +24,12 @@ public interface SiteUserRepository extends JpaRepository<SiteUser, Long> {

@Query("SELECT u FROM SiteUser u WHERE u.quitedAt <= :cutoffDate")
List<SiteUser> findUsersToBeRemoved(@Param("cutoffDate") LocalDate cutoffDate);

@Modifying
@Query("UPDATE SiteUser s SET s.nickname = :nickname, s.nicknameModifiedAt = :modifiedAt WHERE s.id = :id")
void updateNickname(@Param("id") Long id, @Param("nickname") String nickname, @Param("modifiedAt") LocalDateTime modifiedAt);

@Modifying
@Query("UPDATE SiteUser s SET s.profileImageUrl = :profileImageUrl WHERE s.id = :id")
void updateProfileImage(@Param("id") Long id, @Param("profileImageUrl") String profileImageUrl);
Comment thread
whqtker marked this conversation as resolved.
Outdated
Comment thread
whqtker marked this conversation as resolved.
Outdated
}
6 changes: 2 additions & 4 deletions src/main/java/com/example/solidconnection/siteuser/service/MyPageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ public MyPageResponse getMyPageInfo(SiteUser siteUser) {
public void updateMyPageInfo(SiteUser siteUser, MultipartFile imageFile, String nickname) {
if (nickname != null) {
validateNicknameNotChangedRecently(siteUser.getNicknameModifiedAt());
siteUser.setNickname(nickname);
siteUser.setNicknameModifiedAt(LocalDateTime.now());
siteUserRepository.updateNickname(siteUser.getId(), nickname, LocalDateTime.now());
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

if (imageFile != null && !imageFile.isEmpty()) {
Expand All @@ -58,9 +57,8 @@ public void updateMyPageInfo(SiteUser siteUser, MultipartFile imageFile, String
s3Service.deleteExProfile(siteUser);
}
String profileImageUrl = uploadedFile.fileUrl();
siteUser.setProfileImageUrl(profileImageUrl);
siteUserRepository.updateProfileImage(siteUser.getId(), profileImageUrl);
}
siteUserRepository.save(siteUser);
}

private void validateNicknameNotChangedRecently(LocalDateTime lastModifiedAt) {
Expand Down
Loading