This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Clippy cleanup for all targets and nighly rust (also support 1.44.0)#10445
Merged
ryoqun merged 8 commits intosolana-labs:masterfrom Jun 9, 2020
Merged
Clippy cleanup for all targets and nighly rust (also support 1.44.0)#10445ryoqun merged 8 commits intosolana-labs:masterfrom
ryoqun merged 8 commits intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10445 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 296 296
Lines 69340 69320 -20
=========================================
- Hits 56646 56620 -26
- Misses 12694 12700 +6 |
ryoqun
previously requested changes
Jun 8, 2020
Contributor
ryoqun
left a comment
ryoqun
left a comment
There was a problem hiding this comment.
@svenski123 Thank you so much for working on these cleaning ups yet more again!!
So far, very good! Could you check my some comments and rebase to fix the conflicts?
ryoqun
reviewed
Jun 8, 2020
ryoqun
changed the title
minor refactoring in: - cli/src/cli.rs - cli/src/offline/blockhash_query.rs - logger/src/lib.rs - runtime/src/accounts_db.rs expect some performance improvement AccountsDB::clean_accounts()
replace ref-to-arc with ref parameters where arc not cloned
svenski123
force-pushed
the
clippy-cleanup-002
branch
from
bd9fae9 to
e7cd6df
Compare
ryoqun
reviewed
Jun 9, 2020
| let ancestors = HashMap::new(); | ||
| assert!(index.get(&key.pubkey(), &ancestors).is_none()); | ||
| assert!(index.get(&key.pubkey(), Some(&ancestors)).is_none()); | ||
| assert!(index.get(&key.pubkey(), None).is_none()); |
Contributor
There was a problem hiding this comment.
Nice for adding another case for your change. :)
ryoqun
approved these changes
Jun 9, 2020
Contributor
ryoqun
left a comment
ryoqun
left a comment
There was a problem hiding this comment.
LGTM!!! Thanks for working on this!
Contributor
|
This pr was the basis for #10585 . |
This was referenced Jun 16, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Further clippy warning edits, this time for all targets and against rust 1.45.0 (nightly)
Summary of Changes
rustup run nightly cargo clippy --workspace --all-targetsReferences