Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/solana-asm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -190,12 +190,19 @@ jobs:
# latest pnpm fails CI with ERR_PNPM_IGNORED_BUILDS)
npm install --global pnpm@10.33.0

# Install sbpf assembler
cargo install --git https://github.com/blueshift-gg/sbpf.git
# Install sbpf assembler. Pinned to v0.1.9 (0223df0e): the unpinned
# tip moved to v0.2.2, which emits an sBPF binary the runtime loader
# rejects at execution ("Program is not deployed"), breaking every ASM
# example. Keep in sync with the pinned Solana version below.
cargo install --git https://github.com/blueshift-gg/sbpf.git --rev 0223df0e

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The --rev value is an 8-character short SHA. While Git expands short SHAs unambiguously most of the time, using the full 40-character SHA is more portable and explicit — it also makes it clear this is a stable, immutable reference and prevents any future ambiguity if the repo accumulates more commits. The full SHA for 0223df0e can be obtained with git -C <clone> rev-parse 0223df0e.

Suggested change
cargo install --git https://github.com/blueshift-gg/sbpf.git --rev 0223df0e
cargo install --git https://github.com/blueshift-gg/sbpf.git --rev <full-40-char-sha>

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

- name: Setup Solana Stable
uses: heyAyushh/setup-solana@v5.9
with:
solana-cli-version: stable
# Pinned to 4.0.3, the last version the ASM examples passed on (paired
# with sbpf v0.1.9 above). Floating "stable" moved to 4.1.1 in the same
# window the toolchain broke. The beta leg below stays unpinned on
# purpose (it is continue-on-error and tracks the moving channel).
solana-cli-version: 4.0.3
- name: Build and Test with Stable
run: |
source build_and_test.sh
Expand Down
Loading