Merged
Conversation
svazquezco
requested review from
d3rky,
robcsegal and
ruben-sebrango
as code owners
svazquezco
force-pushed
the
MPT-12416-update-mypy-precommit-config
branch
from
a26414e to
659a8d9
Compare
|
alephsur
approved these changes
Jul 30, 2025
d3rky
approved these changes
Jul 30, 2025
| module = "openpyxl.*" | ||
| module = [ | ||
| "click.*", | ||
| "dependency_injector.*", |
Collaborator
There was a problem hiding this comment.
well, I would try to fix it one day :-)
Contributor
Author
There was a problem hiding this comment.
Arrgh! They are not needed! I just forgot to remove them when I added types-openpyxl :(. I'll create a new PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update mypy pre-commit config following -> softwareone-platform/mpt-api-python-client#2