Implement multipart for netty-future, netty-cats & netty-zio#5315
Open
ajozwik wants to merge 1 commit into
Open
Implement multipart for netty-future, netty-cats & netty-zio#5315ajozwik wants to merge 1 commit into
ajozwik wants to merge 1 commit into
Conversation
4841966 to
c1a01be
Compare
78ea9a8 to
8d9e390
Compare
Contributor
Author
|
PR is ready. It can contains more changes - just on master, because I squashed commits with just merged (to master) changes .... Main part is based on MonadSubscriber - implementation of Subscriber - who subscribe to Netty publisher. In implementation java.util.concurrent.Condition is used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal of multipart implementation for netty - see #4851 - only multipart.
Implementation based on
nettyServerSyncimplementation - but without OxStreams.According to Note: Netty's multipart decoder does not expose other part headers, nor other disposition params. the test with netty ignoring part headers -
partOtherHeaderSupport = falseImplementation of
writeBytesToFilefor cats is based on synchronized method, for zio it usedZIO.fromCompletableFutureWhat is missing?
For sync implementation multipart depends on OxStreams - what is not needed and can be moved to other submodule.