feat: add closeFactory/closeClient parameter to usingClient/usingDefaultClient - #2959
Open
mmustafasenoglu wants to merge 1 commit into
Open
feat: add closeFactory/closeClient parameter to usingClient/usingDefaultClient#2959mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
…ultClient The usingClient and usingDefaultClient factory methods on Armeria and OkHttp backends hardcoded closeFactory/closeClient to false, giving users no way to have the backend close a user-provided client. This adds an optional closeFactory/closeClient: Boolean = false parameter to all public factory methods, allowing users to control whether the backend should close the underlying client on backend.close(). Armeria backends (9 files): - ArmeriaCatsBackend (CE3 + CE2) - ArmeriaFutureBackend - ArmeriaFs2Backend (CE3 + CE2) - ArmeriaZioBackend (ZIO 2 + ZIO 1) - ArmeriaMonixBackend - ArmeriaScalazBackend OkHttp backends (2 files): - OkHttpSyncBackend - OkHttpFutureBackend Closes softwaremill#2628
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
closeFactory/closeClient: Boolean = falseparameter to all publicusingClientandusingDefaultClientfactory methods across Armeria (9 backends) and OkHttp (2 backends).Motivation
The
usingClientandusingDefaultClientmethods hardcodedcloseFactorytofalse, giving users no way to have the backend close a user-provided client onbackend.close(). This was reported in #2628.Changes
Armeria backends (9 files):
ArmeriaCatsBackend(CE3 + CE2): addedcloseFactory: Boolean = falsetousingClient,usingDefaultClientArmeriaFutureBackend: sameArmeriaFs2Backend(CE3 + CE2): sameArmeriaZioBackend(ZIO 2 + ZIO 1): same (includingusingClientwith runtime overload)ArmeriaMonixBackend: sameArmeriaScalazBackend: sameOkHttp backends (2 files):
OkHttpSyncBackend: addedcloseClient: Boolean = falsetousingClientOkHttpFutureBackend: sameBackward Compatibility
All changes use default parameter values (
false), so existing code continues to work without modification. MiMa is currently disabled for these subprojects.Testing
Closes #2628