Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s example app/tooling to validate compatibility with React Native 0.85.0-rc.0, plus small RN API adjustments (e.g., StyleSheet.absoluteFill*) that align with newer RN versions.
Changes:
- Bumps
react-nativeand related@react-native/*tooling to0.85.0-rc.0forbasic-exampleand the package dev setup. - Replaces
StyleSheet.absoluteFillObjectwithStyleSheet.absoluteFillacross components/examples. - Updates platform/tooling artifacts (Jest preset config, Gradle wrapper, CocoaPods lockfile, Ruby gems) and refreshes
yarn.lock.
Reviewed changes
Copilot reviewed 14 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Refreshes dependency graph to include RN 0.85 RC and related tooling updates. |
| packages/react-native-gesture-handler/src/components/ReanimatedSwipeable/ReanimatedSwipeable.tsx | Switches to StyleSheet.absoluteFill in styles. |
| packages/react-native-gesture-handler/src/components/ReanimatedDrawerLayout.tsx | Switches to StyleSheet.absoluteFill in styles. |
| packages/react-native-gesture-handler/package.json | Bumps dev RN + RN tooling versions to 0.85.0-rc.0. |
| apps/common-app/src/new_api/showcase/bottom_sheet/index.tsx | Switches to StyleSheet.absoluteFill in styles. |
| apps/common-app/src/legacy/v2_api/bottom_sheet/index.tsx | Switches to StyleSheet.absoluteFill in styles. |
| apps/common-app/src/legacy/showcase/bottomSheet/index.tsx | Uses StyleSheet.absoluteFill in view styles. |
| apps/common-app/src/legacy/recipes/scaleAndRotate/index.tsx | Switches to StyleSheet.absoluteFill in styles. |
| apps/common-app/src/legacy/basic/pagerAndDrawer/index.android.tsx | Switches to StyleSheet.absoluteFill in styles. |
| apps/basic-example/package.json | Bumps react-native and @react-native/* tooling versions to 0.85.0-rc.0. |
| apps/basic-example/jest.config.js | Changes Jest preset to @react-native/jest-preset. |
| apps/basic-example/ios/Podfile.lock | Updates iOS pods/React Native/Hermes versions for RN 0.85 RC. |
| apps/basic-example/android/gradlew.bat | Updates Gradle wrapper script content. |
| apps/basic-example/android/gradlew | Updates Gradle wrapper script content. |
| apps/basic-example/android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle distribution URL. |
| apps/basic-example/android/gradle/wrapper/gradle-wrapper.jar | Updates Gradle wrapper JAR. |
| apps/basic-example/Gemfile.lock | Adds nkf gem to the bundle. |
| apps/basic-example/Gemfile | Adds nkf gem requirement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,3 +1,3 @@ | |||
| module.exports = { | |||
| preset: 'react-native', | |||
| preset: '@react-native/jest-preset', | |||
There was a problem hiding this comment.
jest.config.js switches the preset to @react-native/jest-preset, but apps/basic-example/package.json does not list @react-native/jest-preset in dependencies/devDependencies. Since React Native declares it as an (optional) peer dependency, Jest will fail to resolve the preset unless you add it explicitly (ideally matching the RN version) or revert to the previous react-native preset.
| preset: '@react-native/jest-preset', | |
| preset: 'react-native', |
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.0.0-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip |
There was a problem hiding this comment.
The Gradle wrapper configuration downloads and executes the Gradle distribution from distributionUrl without any checksum or signature verification. If services.gradle.org or the network path is compromised, an attacker could deliver a tampered Gradle 9.3.1 binary that runs arbitrary code in your CI or developer environments. Add a distributionSha256Sum entry for this distribution so the wrapper verifies the artifact’s integrity before executing it.
Description
This PR brings support for React Native 0.85
Note
For now CI fails with
@react-native/jest-preset. Seems like bug in React Native itself, asjest-preset.jsis still not present innode_modules.Status
0.85.0-rc.0 ✅
Test plan
Tested that
basic-examplebuilds and works correctly.