Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a hot reload issue in React Native Gesture Handler where worklets referenced stale callbacks after hot reload. The problem occurred because the callbacks object was rebuilt on hot reload while worklets were not, causing them to reference callbacks that no longer existed.
Changes:
- Added a
didUpdateHandlersflag to track when gesture handlers are updated within a render cycle - Modified the
rebuildparameter passed to Reanimated'suseEventto include thedidUpdateHandlersflag - Removed unnecessary blank line for code formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On hot reload, with reanimated turned on. The first time hot reloads happens when the worklet callback did not change, but the file it was defined it has changed the gesture stops working. The next reload fixes the gesture and all subsequent reloads don't break it.
The reason was that callbacks object was rebuild on first hot reload while worklets were not, which caused the worklets to reference callback which no longer existed. This PR fixes the issue by always rebuilding when the callbacks/handlers object has changed.
Test plan
Tested on the same code this PR, only commenting the first line.