Skip to content

feat(android): text alignment#602

Open
kacperzolkiewski wants to merge 34 commits into
mainfrom
@kacperzolkiewski/text-alignment-android
Open

feat(android): text alignment#602
kacperzolkiewski wants to merge 34 commits into
mainfrom
@kacperzolkiewski/text-alignment-android

Conversation

@kacperzolkiewski
Copy link
Copy Markdown
Collaborator

@kacperzolkiewski kacperzolkiewski commented May 13, 2026

Summary

Adds text alignment for Android
(Note: justify alignment is not natively supported for single spans on Android and will not work).

Test Plan

Run example app and play with textAlignment when different styles are toggled.
Check if paragraphs/lists with different textAlignment than auto are properly parsed and contain style="text-align:center|right" inside HTML

Screenshots / Videos

Screen.Recording.2026-05-20.at.12.06.27.mov

Compatibility

OS Implemented
iOS
Android

Checklist

  • E2E tests are passing
  • Required E2E tests have been added (if applicable)

Base automatically changed from @kacperzolkiewski/text-alignment to main May 15, 2026 14:28
@kacperzolkiewski kacperzolkiewski marked this pull request as ready for review May 20, 2026 10:03
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to modify logic inside list styles?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only behavior we modify in list styles is the handling of ZWS insertion and removal.
We need this because there may already be a ZWS present in a paragraph due to an applied alignment style. In that case, when applying a list style, we don't want to insert another ZWS, we should reuse the existing one.

Similarly, when removing a list style, we don't want to remove the ZWS if it is still needed by alignment style applied to that paragraph.

@kacperzolkiewski kacperzolkiewski requested a review from exploIF June 1, 2026 08:55
@exploIF
Copy link
Copy Markdown
Collaborator

exploIF commented Jun 1, 2026

What's the plan for implementing justify on Android? There is no ready to use span for it, but we should find a different solution and bring justify support as it's pretty base alignement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants