fix: proper gc in the wpt tests - #1246
Open
mdydek wants to merge 6 commits into
Open
Conversation
mdydek
marked this pull request as ready for review
August 20, 2026 17:07
WPT non-regression comparisonPASS — no regressions · 2 improved section(s) · overall 2632 → 2642 (+10)
Per-file data unavailable in one of the reports — category-level comparison only. Unchanged sections (26)
Baseline: Workflow run · this comment is updated on every push. |
mdydek
force-pushed
the
fix/unpin-wpt-windows
branch
from
August 21, 2026 13:48
dd06a52 to
5bca10f
Compare
closetcaiman
added
the
test
Comment on lines
+59
to
66
| /** | ||
| * The spec's [[control thread state]]: written synchronously the moment an | ||
| * operation is accepted, so the NEXT call validates against what has already | ||
| * been requested (e.g. close() right after resume() must see 'running'). | ||
| * Never exposed — the `state` attribute reports acknowledged reality | ||
| * instead. | ||
| */ | ||
| protected _state: ContextState = 'suspended'; |
Member
There was a problem hiding this comment.
Is this field actually needed if we moved the getter to the host object?
| this._state = 'running'; | ||
| return (this.context as IAudioContext).resume(); | ||
| this.setControlState('running'); | ||
| await (this.context as IAudioContext).resume(); |
Member
There was a problem hiding this comment.
If the promise rejects the [[control state]] stays running.
Comment on lines
-73
to
77
| // The driver also starts implicitly, from the first | ||
| // `AudioScheduledSourceNode::start()`. Publish RUNNING here so the visible state | ||
| // Publish RUNNING here so the visible state | ||
| // never reports SUSPENDED while the graph is actually rendering; `resume()` | ||
| // reaches the same state through its promise task. | ||
| // reaches the same state through its promise task (its dispatch then | ||
| // dedupes against this one). | ||
| setState(ContextState::RUNNING); |
Member
There was a problem hiding this comment.
Actually it does not. It only flips the atomic state flag. (?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Checklist