feat: encoder by mdydek · Pull Request #1183 · software-mansion/react-native-audio-api

mdydek · 2026-07-21T11:19:36Z

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

Linked relevant issue
Updated relevant documentation
Added/Conducted relevant tests
Performed self-review of the code
Updated Web Audio API coverage
Added support for web
Updated old arch android spec file

Resolves conflicts between the encoder work and the OS-APIs decoding refactor (#1177): - AudioFileConcatenator: main's decoder-factory WAV path + encoder's OS remux (M4A/MP4) path; all FFmpeg remux code removed - AudioEventHandlerRegistry -> IAudioEventHandlerRegistry (#1212) in encoder file writers - AndroidEncoding/AndroidRemux moved to android/src/main/cpp/audioapi/android/ to match AndroidDecoding placement - docs/flags updated: recording and concatAudioFiles are FFmpeg-free Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

github-actions · 2026-08-18T08:13:33Z

WPT non-regression comparison

ERROR — the comparison did not produce a report; the test run itself likely failed.

_{Workflow run · this comment is updated on every push.}

closetcaiman

Please add description to the PR for fast-access reference to the scope of these changes.

closetcaiman · 2026-08-21T12:16:23Z

+// Packs @p numberOfChannels planar channel pointers into one channel-interleaved buffer.
+// @p outputInterleaved must hold numberOfFrames * numberOfChannels floats.
+void interleave(
+    const float *const *inputChannels,
+    size_t numberOfChannels,
+    float *outputInterleaved,
+    size_t numberOfFrames);
+
+// Splits a channel-interleaved buffer into @p numberOfChannels planar channel pointers,
+// each of which must hold numberOfFrames floats.
+void deinterleave(
+    const float *inputInterleaved,
+    float *const *outputChannels,
+    size_t numberOfChannels,
+    size_t numberOfFrames);
+
 } // namespace audioapi::dsp


Is this intended to be reused for (de)interleaving AudioBuffers?

closetcaiman · 2026-08-21T12:43:15Z

+void RotatingFileWriter::writeAudioData(const float *interleavedFrames, int numFrames) {
+  if (currentWriter_ == nullptr) {
+    return;
+  }
+
+  currentWriter_->writeAudioData(interleavedFrames, numFrames);
+
+  writesSinceLastCheck_++;
+  if (writesSinceLastCheck_ >= FILE_SIZE_CHECK_WRITE_INTERVAL) {
+    writesSinceLastCheck_ = 0;
+    if (currentWriter_->getFileSizeBytes() > rotateIntervalBytes_) {
+      rotateFiles();
+    }
+  }
+}
+


Why we ignore the result here? Should we fire an event? This seems really dangerous to me.

closetcaiman · 2026-08-21T12:55:50Z

+std::vector<EncoderOutputSpec> EncoderCapabilities::probe() {
+#ifdef __APPLE__
+  return {
+      {.container = AudioContainer::WAV, .codec = AudioCodec::PCM, .extension = "wav"},
+      {.container = AudioContainer::CAF, .codec = AudioCodec::PCM, .extension = "caf"},
+      {.container = AudioContainer::AIFF, .codec = AudioCodec::PCM, .extension = "aiff"},
+      {.container = AudioContainer::M4A, .codec = AudioCodec::AAC, .extension = "m4a"},
+      {.container = AudioContainer::M4A, .codec = AudioCodec::ALAC, .extension = "m4a"},
+      {.container = AudioContainer::FLAC, .codec = AudioCodec::FLAC, .extension = "flac"},
+      {.container = AudioContainer::WAV, .codec = AudioCodec::ULAW, .extension = "wav"},
+      {.container = AudioContainer::WAV, .codec = AudioCodec::ALAW, .extension = "wav"},
+  };
+#elif defined(__ANDROID__)
+  return {
+      {.container = AudioContainer::WAV, .codec = AudioCodec::PCM, .extension = "wav"},
+      {.container = AudioContainer::M4A, .codec = AudioCodec::AAC, .extension = "m4a"},
+      {.container = AudioContainer::FLAC, .codec = AudioCodec::FLAC, .extension = "flac"},
+      {.container = AudioContainer::OGG, .codec = AudioCodec::OPUS, .extension = "ogg"},
+      {.container = AudioContainer::WEBM, .codec = AudioCodec::OPUS, .extension = "webm"},
+      {.container = AudioContainer::WEBM, .codec = AudioCodec::VORBIS, .extension = "webm"},
+  };
+#else
+  return {};
+#endif
+}


probe name seems misleading as we are not actually probing anything here. Maybe this could be just a static field?

closetcaiman · 2026-08-21T12:56:42Z

+EncoderOutputSpec EncoderCapabilities::specForFormat(Format format) {
+  switch (format) {
+    case Format::WAV:
+      return {.container = AudioContainer::WAV, .codec = AudioCodec::PCM, .extension = "wav"};
+    case Format::CAF:
+      return {.container = AudioContainer::CAF, .codec = AudioCodec::PCM, .extension = "caf"};
+    case Format::M4A:
+      return {.container = AudioContainer::M4A, .codec = AudioCodec::AAC, .extension = "m4a"};
+    case Format::FLAC:
+      return {.container = AudioContainer::FLAC, .codec = AudioCodec::FLAC, .extension = "flac"};
+    case Format::AIFF:
+      return {.container = AudioContainer::AIFF, .codec = AudioCodec::PCM, .extension = "aiff"};
+    case Format::ALAC:
+      return {.container = AudioContainer::M4A, .codec = AudioCodec::ALAC, .extension = "m4a"};
+    case Format::OPUS_OGG:
+      return {.container = AudioContainer::OGG, .codec = AudioCodec::OPUS, .extension = "ogg"};
+    case Format::OPUS_WEBM:
+      return {.container = AudioContainer::WEBM, .codec = AudioCodec::OPUS, .extension = "webm"};
+    case Format::VORBIS_WEBM:
+      return {.container = AudioContainer::WEBM, .codec = AudioCodec::VORBIS, .extension = "webm"};
+    case Format::ULAW:
+      return {.container = AudioContainer::WAV, .codec = AudioCodec::ULAW, .extension = "wav"};
+    case Format::ALAW:
+      return {.container = AudioContainer::WAV, .codec = AudioCodec::ALAW, .extension = "wav"};
+  }
+  return {.container = AudioContainer::WAV, .codec = AudioCodec::PCM, .extension = "wav"};
+}
+


Same case as with probe. We can just hardcode this, then EncoderCapabilites can probably be just a namespace.

closetcaiman · 2026-08-21T13:11:25Z

getFormat is not used anymore, same for getFileSettings.

closetcaiman · 2026-08-21T13:22:44Z

+OpenFileResult RotatingFileWriter::openFile(
+    float streamSampleRate,
+    int32_t streamChannelCount,
+    int32_t maxFramesPerBuffer,
+    const std::string &fileNameOverride) {
+  streamSampleRate_ = streamSampleRate;
+  streamChannelCount_ = streamChannelCount;
+  maxFramesPerBuffer_ = maxFramesPerBuffer;
+
+  if (!fileNameOverride.empty()) {
+    fileProperties_->fileNamePrefix = fileNameOverride + fileProperties_->fileNamePrefix;
+  }
+  if (currentWriter_ == nullptr) {
+    currentWriter_ = writerFactory_(fileProperties_);
+  }
+
+  return openInnerWriter();
+}
+


This is not idempotent in terms of fileProperties_->fileNamePrefix. If I understand the flow correctly, re-preparing can create a weird-concatented name.

closetcaiman · 2026-08-21T13:27:57Z

+  if (usesFileOutput()) {
+    auto fileWriterLock = Locker::tryLock(fileWriterMutex_);
+    if (fileWriterLock && fileWriter_) {
+      // if we are inside the lock and the fileWriter_ is valid we can be sure that nobody will interrupt us in the middle
+      fileWriter_->writeAudioData(interleavedFrames, numFrames);
+    }
+  }
+


The call chain causes the file rotation to be invoked on AudioThread.

maciejmakowski2003

could you add an overview of refactor? would be great to get some diagram

mdydek and others added 4 commits July 21, 2026 13:19

feat: 1st version of encoder

d34ce7f

feat: remove unnecessary formats

5c76ba2

feat: 2nd version of encoders

42d9269

mdydek changed the title ~~feat: 1st version of encoder~~ feat: encoder Aug 12, 2026

closetcaiman added the feature New user-facing features or major capabilities label Aug 12, 2026

mdydek mentioned this pull request Aug 14, 2026

Exclude FFmpeg headers from npm artifact to avoid LGPL license issues for consumers with FFmpeg disabled #1173

Open

Merge branch 'main' into feat/encoder-interface

1b22746

feat: 3 codecs can be concatenated

8c61e1e

mdydek marked this pull request as ready for review August 18, 2026 08:35

mdydek requested a review from maciejmakowski2003 as a code owner August 18, 2026 08:35

mdydek added 4 commits August 18, 2026 11:04

Merge branch 'main' into feat/encoder-interface

afa2b05

fix: ci

303d8f1

Merge branch 'main' into feat/encoder-interface

6398c34

refactor: put common code in the base class

e254f1c

closetcaiman requested changes Aug 21, 2026

View reviewed changes

maciejmakowski2003 requested changes Aug 21, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

feat: encoder - #1183

feat: encoder#1183
mdydek wants to merge 10 commits into
mainfrom
feat/encoder-interface

mdydek commented Jul 21, 2026

Uh oh!

github-actions Bot commented Aug 18, 2026 •

edited

Loading

Uh oh!

closetcaiman left a comment

Uh oh!

closetcaiman Aug 21, 2026

Uh oh!

closetcaiman Aug 21, 2026

Uh oh!

closetcaiman Aug 21, 2026 •

edited

Loading

Uh oh!

closetcaiman Aug 21, 2026 •

edited

Loading

Uh oh!

closetcaiman Aug 21, 2026

Uh oh!

closetcaiman Aug 21, 2026 •

edited

Loading

Uh oh!

closetcaiman Aug 21, 2026

Uh oh!

maciejmakowski2003 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

mdydek commented Jul 21, 2026

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

Uh oh!

github-actions Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WPT non-regression comparison

Uh oh!

closetcaiman left a comment

Choose a reason for hiding this comment

Uh oh!

closetcaiman Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

closetcaiman Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

closetcaiman Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

closetcaiman Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

closetcaiman Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

closetcaiman Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

closetcaiman Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

maciejmakowski2003 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Aug 18, 2026 •

edited

Loading

closetcaiman Aug 21, 2026 •

edited

Loading

closetcaiman Aug 21, 2026 •

edited

Loading

closetcaiman Aug 21, 2026 •

edited

Loading