Skip to content

fix(android): resolve worklets via prefab to avoid missing libworklets.so on fresh builds#1076

Open
msluszniak wants to merge 1 commit into
software-mansion:mainfrom
msluszniak:@ms/worklets-prefab-lookup
Open

fix(android): resolve worklets via prefab to avoid missing libworklets.so on fresh builds#1076
msluszniak wants to merge 1 commit into
software-mansion:mainfrom
msluszniak:@ms/worklets-prefab-lookup

Conversation

@msluszniak
Copy link
Copy Markdown
Member

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

  • Resolve libworklets.so via find_package(react-native-worklets CONFIG) instead of hardcoding AGP's legacy intermediates/cmake/<type>/obj/<abi>/libworklets.so path. AGP 8 populates that path only for consumed prefab dependencies, never for a module's own output — cold-cache builds therefore fail with missing and no known rule to make it. The legacy path is kept as a fallback when the prefab lookup is unavailable (older worklets versions).
  • Mirrors the equivalent fix in expo-modules-core (fix(expo-modules-core): resolve libworklets.so via prefab before falling back to local CMake output expo/expo#43863).

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant