Skip to content

docs: Fix "Vaporrave" on WebKit (vec3f->vec4f) #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iwoplaza merged 1 commit into from
Aug 5, 2026
+19 −11
Merged

docs: Fix "Vaporrave" on WebKit (vec3f->vec4f) #2782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions apps/typegpu-docs/src/examples/simple/vaporrave/scene.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ export async function setupScene(root: TgpuRoot, context: GPUCanvasContext) {
const sphereAngleUniform = root.createUniform(d.f32);
const glowIntensityUniform = root.createUniform(d.f32, c.INITIAL_GLOW_INTENSITY);
const resolutionUniform = root.createUniform(d.vec2f);
const sphereColorUniform = root.createUniform(d.vec3f, c.initialSphereColor);
// NOTE: Padded to vec4f on purpose. A bare vec3f uniform triggers a WebKit
// WGSL->Metal codegen bug on iOS/Safari (missing `__unpack` overload for a
// `packed_float3` uniform), which fails shader compilation.
Comment on lines +20 to +22

@reczkok reczkok Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's crazy to me that this is still a bug

const sphereColorUniform = root.createUniform(d.vec4f, d.vec4f(c.initialSphereColor, 1));

let floorSpeed = 0.25;
let sphereSpeed = 1;
Expand All @@ -35,7 +38,7 @@ export async function setupScene(root: TgpuRoot, context: GPUCanvasContext) {
dist: sdPlane(p, c.planeOrthonormal, c.PLANE_OFFSET),
color: floorPatternSlot.$(p.xz, floorAngleUniform.$),
});
const sphere = getSphere(p, sphereColorUniform.$, c.sphereCenter, sphereAngleUniform.$);
const sphere = getSphere(p, sphereColorUniform.$.rgb, c.sphereCenter, sphereAngleUniform.$);

return rayUnion(floor, sphere);
});
Expand All @@ -53,9 +56,14 @@ export async function setupScene(root: TgpuRoot, context: GPUCanvasContext) {
for (let i = 0; i < c.MAX_STEPS; i++) {
const p = rd * distOrigin + ro;
const scene = getSceneRay(p);
const sphereDist = getSphere(p, sphereColorUniform.$, c.sphereCenter, sphereAngleUniform.$);
const sphereDist = getSphere(
p,
sphereColorUniform.$.rgb,
c.sphereCenter,
sphereAngleUniform.$,
);

glow += d.vec3f(sphereColorUniform.$) * std.exp(-sphereDist.dist);
glow += sphereColorUniform.$.rgb * std.exp(-sphereDist.dist);

distOrigin += scene.dist;

Expand Down Expand Up @@ -166,7 +174,7 @@ export async function setupScene(root: TgpuRoot, context: GPUCanvasContext) {
sphereSpeed = value;
},
set sphereColor(value: d.v3f) {
sphereColorUniform.write(value);
sphereColorUniform.write(d.vec4f(value, 1));
},
set floorPattern(value: 'grid' | 'circles') {
renderPipeline = root
Expand Down
12 changes: 6 additions & 6 deletions apps/typegpu-docs/tests/individual-example-tests/vaporrave.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ describe('vaporrave example', () => {
return (dot(point, normal) + height);
}

@group(0) @binding(2) var<uniform> sphereColorUniform: vec4f;

fn rotateAroundZ(angle: f32) -> mat3x3f {
return mat3x3f(vec3f(cos(angle), sin(angle), 0f), vec3f(-(sin(angle)), cos(angle), 0f), vec3f(0, 0, 1));
}
Expand All @@ -116,7 +118,7 @@ describe('vaporrave example', () => {
return (length(point) - radius);
}

@group(0) @binding(2) var<storage, read> memoryBuffer: array<vec3f, 343>;
@group(0) @binding(3) var<storage, read> memoryBuffer: array<vec3f, 343>;

fn getJunctionGradient(pos: vec3i) -> vec3f {
let size_i = vec3i(7);
Expand Down Expand Up @@ -171,8 +173,6 @@ describe('vaporrave example', () => {
return Ray(sphereColor, (rawDist + noise));
}

@group(0) @binding(3) var<uniform> sphereColorUniform: vec3f;

@group(0) @binding(4) var<uniform> sphereAngleUniform: f32;

fn rayUnion(a: Ray, b: Ray) -> Ray {
Expand All @@ -181,7 +181,7 @@ describe('vaporrave example', () => {

fn getSceneRay(p: vec3f) -> Ray {
let floor_1 = Ray(circles(p.xz, floorAngleUniform), sdPlane(p, vec3f(0, 1, 0), 1f));
let sphere = getSphere(p, sphereColorUniform, vec3f(0, 6, 12), sphereAngleUniform);
let sphere = getSphere(p, sphereColorUniform.rgb, vec3f(0, 6, 12), sphereAngleUniform);
return rayUnion(floor_1, sphere);
}

Expand All @@ -197,8 +197,8 @@ describe('vaporrave example', () => {
for (var i = 0; (i < 1000i); i++) {
let p = ((rd * distOrigin) + ro);
let scene = getSceneRay(p);
let sphereDist = getSphere(p, sphereColorUniform, vec3f(0, 6, 12), sphereAngleUniform);
glow += (sphereColorUniform * exp(-(sphereDist.dist)));
let sphereDist = getSphere(p, sphereColorUniform.rgb, vec3f(0, 6, 12), sphereAngleUniform);
glow += (sphereColorUniform.rgb * exp(-(sphereDist.dist)));
distOrigin += scene.dist;
if ((distOrigin > 19f)) {
result.dist = 19f;
Expand Down
Loading