[all] Remove SOFA_ATTRIBUTE_DISABLED (#5309)

* [all] Remove SOFA_ATTRIBUTE_DISABLED for v23.12 and start v24.06

* continue removing disabled attributes

* update response method

* continue SOFA_ATTRIBUTE_DISABLED on RigidMapping and DiagonalVelocityDamping

* continue SOFA_ATTRIBUTE_DISABLED BaseMechanicalVisitor

* remove unused nodeData

* continue SOFA_ATTRIBUTE_DISABLED in OptionsGroup and Visitor

* continue SOFA_ATTRIBUTE_DISABLED in SparseCommon

* Complete removal of SOFA_ATTRIBUTE_DISABLED with Node

---------

Co-authored-by: Frederick Roy <froy@lnrobo.com>

Author: hugtalbot

Sofa/Component/Collision/Detection/Algorithm/src/sofa/component/collision/detection/algorithm/DirectSAPNarrowPhase.h

@@ -63,9 +63,6 @@ class SOFA_COMPONENT_COLLISION_DETECTION_ALGORITHM_API DirectSAPNarrowPhase : pu
       */
     void updateBoxes();
 
-    SOFA_ATTRIBUTE_DISABLED__DRAWNARROWPHASE()
-    sofa::core::objectmodel::lifecycle::RemovedData d_draw{this, "v23.12", "v24.06", "draw", "Use display flag 'showDetectionOutputs' instead"}; ///< enable/disable display of results
-
     Data<bool> d_showOnlyInvestigatedBoxes; ///< Show only boxes which will be sent to narrow phase
     Data<int> d_nbPairs; ///< number of pairs of elements sent to narrow phase
 

Sofa/Component/Collision/Detection/Algorithm/src/sofa/component/collision/detection/algorithm/RayTraceNarrowPhase.h

@@ -44,10 +44,6 @@ class SOFA_COMPONENT_COLLISION_DETECTION_ALGORITHM_API RayTraceNarrowPhase : pub
 public:
     SOFA_CLASS(RayTraceNarrowPhase, core::collision::NarrowPhaseDetection);
 
-private:
-    SOFA_ATTRIBUTE_DISABLED__DRAWNARROWPHASE()
-    sofa::core::objectmodel::lifecycle::RemovedData bDraw{this, "v23.12", "v24.06", "draw", "Use display flag 'showDetectionOutputs' instead"}; ///< enable/disable display of results
-
 protected:
     RayTraceNarrowPhase() = default;
 

Sofa/Component/Collision/Detection/Algorithm/src/sofa/component/collision/detection/algorithm/config.h.in

@@ -31,23 +31,6 @@
 #  define SOFA_COMPONENT_COLLISION_DETECTION_ALGORITHM_API SOFA_IMPORT_DYNAMIC_LIBRARY
 #endif
 
-#ifdef SOFA_BUILD_SOFA_COMPONENT_COLLISION_DETECTION_ALGORITHM
-#define SOFA_ATTRIBUTE_DISABLED__RENAME_COLLISIONPIPELINE()
-#else
-#define SOFA_ATTRIBUTE_DISABLED__RENAME_COLLISIONPIPELINE() \
-    SOFA_ATTRIBUTE_DISABLED( \
-        "v23.06", "v23.12", \
-        "DefaultPipeline renamed as CollisionPipeline in #3590: sofa/component/collision/detection/algorithm/CollisionPipeline.h")
-#endif
-
-#ifdef SOFA_BUILD_SOFA_COMPONENT_COLLISION_DETECTION
-#  define SOFA_ATTRIBUTE_DISABLED__DRAWNARROWPHASE()
-#else
-# define SOFA_ATTRIBUTE_DISABLED__DRAWNARROWPHASE() \
-    SOFA_ATTRIBUTE_DISABLED( \
-        "v23.12", "v24.06", "This data is not used anymore: the drawing is now controlled by a draw flag")
-#endif
-
 #ifdef SOFA_BUILD_SOFA_COMPONENT_COLLISION_DETECTION_ALGORITHM
 #define SOFA_ATTRIBUTE_DEPRECATED__RENAME_DATA_IN_COLLISION_DETECTION_ALGORITHM()
 #else

Sofa/Component/Collision/Response/Contact/src/sofa/component/collision/response/contact/CollisionResponse.h

@@ -67,28 +67,6 @@ public :
         if (arg)
             obj->parse(arg);
 
-        //SOFA_ATTRIBUTE_DISABLED("v21.12 (PR#2522)", "v24.06","This attribute was only added to build a compatibility layer on the response name.")
-        {
-            static const std::map<std::string,std::string> renamingResponseMethod = {
-                {"ray", "RayContact"},
-                {"default", "PenalityContactForceField"},
-                {"FrictionContact", "FrictionContactConstraint"},
-                {"registration", "RegistrationContactForceField"},
-                {"stick", "StickContactForceField"},
-            };
-
-            const std::string responseDesired = arg->getAttribute("response","");
-            const auto it = renamingResponseMethod.find(responseDesired);
-
-            if(it != renamingResponseMethod.end())
-            {
-                msg_error("CollisionResponse")
-                    << "Option \"" << it->first << "\" "
-                    << "for data \"response\" has been renamed since v21.12 (PR#2522). "
-                    << "Use \"" << it->second << "\" instead.";
-            }
-        }
-        
         return obj;
     }
 

Sofa/Component/Collision/Response/Mapper/src/sofa/component/collision/response/mapper/BarycentricContactMapper.h

@@ -53,9 +53,6 @@ class BarycentricContactMapper : public BaseContactMapper<TDataTypes>
     typename MMapping::SPtr mapping;
     typename MMapper::SPtr mapper;
 
-    SOFA_ATTRIBUTE_REPLACED__TYPEMEMBER(Index, sofa::Index);
-    SOFA_ATTRIBUTE_REPLACED__TYPEMEMBER(Size, sofa::Size);
-
     BarycentricContactMapper()
         : model(nullptr), mapping(nullptr), mapper(nullptr)
     {

Sofa/Component/Collision/Response/Mapper/src/sofa/component/collision/response/mapper/TetrahedronBarycentricContactMapper.h

@@ -34,7 +34,6 @@ template<class DataTypes>
 class ContactMapper<collision::geometry::TetrahedronCollisionModel, DataTypes> : public BarycentricContactMapper<collision::geometry::TetrahedronCollisionModel, DataTypes>
 {
 public:
-    SOFA_ATTRIBUTE_REPLACED__TYPEMEMBER(Index, sofa::Index);
     typedef typename DataTypes::Real Real;
     typedef typename DataTypes::Coord Coord;
     sofa::Index addPoint(const Coord& P, sofa::Index index, Real&)

Sofa/Component/Constraint/Lagrangian/Solver/src/sofa/component/constraint/lagrangian/solver/GenericConstraintSolver.h

@@ -149,7 +149,6 @@ class SOFA_COMPONENT_CONSTRAINT_LAGRANGIAN_SOLVER_API GenericConstraintSolver :
     sofa::type::fixed_array<GenericConstraintProblem, CP_BUFFER_SIZE> m_cpBuffer;
     sofa::type::fixed_array<bool, CP_BUFFER_SIZE> m_cpIsLocked;
     GenericConstraintProblem *current_cp, *last_cp;
-    SOFA_ATTRIBUTE_DISABLED__GENERICCONSTRAINTSOLVER_CONSTRAINTCORRECTIONS() DeprecatedAndRemoved constraintCorrections; //use ConstraintSolverImpl::l_constraintCorrections instead
 
     sofa::core::MultiVecDerivId m_lambdaId;
     sofa::core::MultiVecDerivId m_dxId;

Sofa/Component/Constraint/Lagrangian/Solver/src/sofa/component/constraint/lagrangian/solver/LCPConstraintSolver.h

@@ -167,7 +167,6 @@ class SOFA_COMPONENT_CONSTRAINT_LAGRANGIAN_SOLVER_API LCPConstraintSolver : publ
     void keepContactForcesValue();
 
     unsigned int _numConstraints;
-    SOFA_ATTRIBUTE_DEPRECATED__LCPCONSTRAINTSOLVERMUMEMBER() DeprecatedAndRemoved _mu;
 
     /// Multigrid hierarchy is resized and cleared
     void buildHierarchy();

Sofa/Component/Constraint/Lagrangian/Solver/src/sofa/component/constraint/lagrangian/solver/config.h.in

@@ -38,23 +38,6 @@ namespace sofa::component::constraint::lagrangian::solver
 } // namespace sofa::component::constraint::lagrangian::solver
 
 
-// deprecate _mu as member
-#ifdef SOFA_BUILD_SOFA_COMPONENT_CONSTRAINT_LAGRANGIAN_SOLVER
-#define SOFA_ATTRIBUTE_DEPRECATED__LCPCONSTRAINTSOLVERMUMEMBER()
-#else
-#define SOFA_ATTRIBUTE_DEPRECATED__LCPCONSTRAINTSOLVERMUMEMBER() \
-    SOFA_ATTRIBUTE_DISABLED( \
-        "v23.12", "v24.06", "_mu is not a member anymore. Use the Data \"mu\" to get the friction value.")
-#endif // SOFA_BUILD_SOFA_COMPONENT_CONSTRAINT_LAGRANGIAN_SOLVER
-
-#ifdef SOFA_BUILD_SOFA_COMPONENT_CONSTRAINT_LAGRANGIAN_SOLVER
-#define SOFA_ATTRIBUTE_DISABLED__GENERICCONSTRAINTSOLVER_CONSTRAINTCORRECTIONS()
-#else
-#define SOFA_ATTRIBUTE_DISABLED__GENERICCONSTRAINTSOLVER_CONSTRAINTCORRECTIONS() \
-    SOFA_ATTRIBUTE_DISABLED( \
-        "v23.12", "v23.12", "Use ConstraintSolverImpl::l_constraintCorrections instead")
-#endif // SOFA_BUILD_SOFA_COMPONENT_CONSTRAINT_LAGRANGIAN_SOLVER
-
 #ifdef SOFA_BUILD_SOFA_COMPONENT_CONSTRAINT_LAGRANGIAN_SOLVER
 #define SOFA_ATTRIBUTE_DEPRECATED__RENAME_DATA_IN_CONSTRAINT_LAGRANGIAN_SOLVER()
 #else

Sofa/Component/Constraint/Projective/src/sofa/component/constraint/projective/DirectionProjectiveConstraint.h

@@ -69,7 +69,6 @@ class DirectionProjectiveConstraint : public core::behavior::ProjectiveConstrain
     typedef Data<VecDeriv> DataVecDeriv;
     typedef Data<MatrixDeriv> DataMatrixDeriv;
     typedef type::vector<Index> Indices;
-    SOFA_ATTRIBUTE_REPLACED__TYPEMEMBER(Vector3, sofa::type::Vec3);
     typedef sofa::core::topology::TopologySubsetIndices IndexSubsetData;
     typedef linearalgebra::EigenBaseSparseMatrix<SReal> BaseSparseMatrix;
     typedef linearalgebra::EigenSparseMatrix<DataTypes,DataTypes> SparseMatrix;