Skip to content

Add regression test for cancelling pool gardener #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuel-williams-shopify merged 1 commit into from
Jul 28, 2026
Merged

Add regression test for cancelling pool gardener #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions test/async/pool/controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,4 +486,19 @@ def failures(repeats: 500, time_scale: 0.001, &block)
pool.close
end
end

with "cancellation while waiting" do
it "cancels the gardener when closing the pool" do
# Regression test for https://bugs.ruby-lang.org/issues/20907.
# Allocating a resource starts the gardener, which then parks in `#wait`:
resource = pool.acquire
gardener = pool.instance_variable_get(:@gardener)
pool.release(resource)

# This stops the gardener while it is waiting:
pool.close

expect(gardener.wait).to be_nil
end
end
end
Loading