Skip to content

Make traces and metrics optional #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ioquatix merged 5 commits into from
Jul 22, 2026
Merged

Make traces and metrics optional #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d950295
Make traces and metrics optional
ioquatix Jul 22, 2026
5215bae
Cover traced client protocol requests
ioquatix Jul 22, 2026
0026b4d
Cover HTTP2 protocol pseudo-header
ioquatix Jul 22, 2026
7d16f68
Revert "Cover HTTP2 protocol pseudo-header"
ioquatix Jul 22, 2026
20ae0b3
Revert "Cover traced client protocol requests"
ioquatix Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions async-http.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ Gem::Specification.new do |spec|
spec.add_dependency "async-pool", "~> 0.11"
spec.add_dependency "io-endpoint", "~> 0.14"
spec.add_dependency "io-stream", "~> 0.6"
spec.add_dependency "metrics", "~> 0.12"
spec.add_dependency "protocol-http", "~> 0.62"
spec.add_dependency "protocol-http1", "~> 0.39"
spec.add_dependency "protocol-http2", "~> 0.26"
spec.add_dependency "protocol-url", "~> 0.2"
spec.add_dependency "traces", "~> 0.10"
end
2 changes: 2 additions & 0 deletions gems.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
gem "rubocop"
gem "rubocop-md"
gem "rubocop-socketry"
gem "metrics", "~> 0.12"
gem "traces", "~> 0.10"

gem "sus-fixtures-async"
gem "sus-fixtures-async-http", "~> 0.8"
Expand Down
1 change: 1 addition & 0 deletions lib/traces/provider/async/http/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Copyright, 2025, by Samuel Williams.

require_relative "../../../../async/http/client"
require "traces/provider"

Traces::Provider(Async::HTTP::Client) do
def call(request)
Expand Down
1 change: 1 addition & 0 deletions lib/traces/provider/async/http/protocol/http1/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Copyright, 2025, by Samuel Williams.

require_relative "../../../../../../async/http/protocol/http1/client"
require "traces/provider"

Traces::Provider(Async::HTTP::Protocol::HTTP1::Client) do
def write_request(...)
Expand Down
1 change: 1 addition & 0 deletions lib/traces/provider/async/http/protocol/http2/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Copyright, 2025, by Samuel Williams.

require_relative "../../../../../../async/http/protocol/http2/client"
require "traces/provider"

Traces::Provider(Async::HTTP::Protocol::HTTP2::Client) do
def write_request(...)
Expand Down
1 change: 1 addition & 0 deletions lib/traces/provider/async/http/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Copyright, 2025, by Samuel Williams.

require_relative "../../../../async/http/server"
require "traces/provider"

Traces::Provider(Async::HTTP::Server) do
def call(request)
Expand Down
4 changes: 4 additions & 0 deletions releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Releases

## Unreleased

- Made `metrics` and `traces` optional runtime dependencies. Applications that use the providers should depend on the corresponding gem and require the provider explicitly.

## v0.95.1

- Fix handling of reset stream causing complete connection failure.
Expand Down
Loading