Skip to content

fix(sio): parse Engine.v3 namespace query without Object.fromEntries #5537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FirmaSpring wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix(sio): parse Engine.v3 namespace query without Object.fromEntries #5537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/socket.io/lib/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ import type { Socket as RawSocket } from "engine.io";

const debug = debugModule("socket.io:client");

function objectFromEntries(
entries: Iterable<readonly [PropertyKey, string]>,
): Record<string, string> {
const obj: Record<string, string> = Object.create(null);
for (const [key, value] of entries) {
obj[key as string] = value;
}
return obj;
}

interface WriteOptions {
compress?: boolean;
volatile?: boolean;
Expand Down Expand Up @@ -296,7 +306,7 @@ export class Client<
const url = new URL(packet.nsp, "https://socket.io");
return {
namespace: url.pathname,
authPayload: Object.fromEntries(url.searchParams.entries()),
authPayload: objectFromEntries(url.searchParams.entries()),
};
}

Expand Down