fix(eio): use Node 10-safe query parser on the uWS server - #5536
Open
FirmaSpring wants to merge 1 commit into
Open
fix(eio): use Node 10-safe query parser on the uWS server#5536FirmaSpring wants to merge 1 commit into
FirmaSpring wants to merge 1 commit into
Conversation
The HTTP server path was restored in ae7fb46, but userver still called Object.fromEntries. Co-authored-by: FirmamentalSpring <287222957+FirmaSpring@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
engine.iostill advertisesengines.node: >=10.2.0. The HTTP server path was restored to a Node 10-compatible query parser in ae7fb46, but the uWebSockets server still parses the query string withObject.fromEntries(), which does not exist on Node 10/11.A handshake on the uWS transport therefore throws before validation on the Node versions the package still claims to support.
New behavior
packages/engine.io/lib/userver.tsnow uses the existingobjectFromEntrieshelper, matchingserver.ts.Other information (e.g. related issues)
Follow-up to #5527 / ae7fb46. The HTTP path is already fixed; this is the leftover uWS call site.