feat: integrate HTML config dialog from Language Server [IDE-1458] #426

nick-y-snyk · 2025-12-15T14:33:03Z

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

Read and understood the Code of Conduct and Contributing Guidelines.
Tests added and all succeed
Linted
CHANGELOG.md updated
README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

snyk-io · 2025-12-15T14:33:16Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

… files in sync

nick-y-snyk · 2025-12-17T12:41:33Z

dropping internalautoscan property because it's already handled in ls

Introduces BaseSnykUserControl to eliminate duplicate settings synchronization code across all WinForms settings pages. When settings change in the HTML modal window, the base class automatically reloads from disk and updates all WinForms controls. Key changes: - Add BaseSnykUserControl base class with SettingsChanged event handling - Extend Language Server initialization options with new settings (BaseUrl, RiskScoreThreshold, FilterSeverity, AdditionalEnv) - Remove InternalAutoScan flag and auto-scan trigger logic from Language Client - Add severity filter properties (FilterCritical/High/Medium/Low) to options - Implement GetAdditionalEnvAsync/SaveAdditionalEnvAsync in SnykOptionsManager - Update all UserControls to inherit from BaseSnykUserControl - Add logging and error handling to HTML settings window - Extend ScanCommandConfig with pre/post scan command properties

andrewrobinsonhodges-snyk · 2025-12-18T15:17:59Z

Snyk.VisualStudio.Extension.2022/Language/LanguageServerCommands.cs

+        /// <returns>HTML string for configuration UI, or null if unavailable</returns>
+        public static async Task<string> GetConfigHtmlAsync(IJsonRpc rpc, CancellationToken cancellationToken = default)
+        {
+            if (rpc == null) return null;


Might be worth adding a log here? Not sure how common this will be.

Snyk.VisualStudio.Extension.2022/Language/LsAnalysisResult.cs

andrewrobinsonhodges-snyk · 2025-12-18T15:22:08Z

Snyk.VisualStudio.Extension.2022/Language/LsAnalysisResult.cs

+            }
+
+            // Fallback: try priorityScore first, then riskScore
+            return AdditionalData.PriorityScore > 0


Why do we need a fallback? Would Product not always be set?

Snyk.VisualStudio.Extension.2022/Language/LsSettings.cs

Snyk.VisualStudio.Extension.2022/Settings/FeatureFlags.cs

Snyk.VisualStudio.Extension.2022/Settings/HtmlSettingsWindow.xaml.cs

Snyk.VisualStudio.Extension.2022/Settings/SnykSolutionOptionsUserControl.cs

Snyk.VisualStudio.Extension.2022/UI/Html/ConfigScriptingBridge.cs

- Migrate to regex-based CSS variable replacement (inspired by IntelliJ plugin) - Replace var(--vscode-*, fallback) patterns with actual VS theme colors - Fix scrollbar theming to adapt properly to dark/light themes - Use proper VS tool window colors for consistent theming across all elements - Add browser feature control keys for better WebBrowser rendering - Adjust modal window dimensions for better content display - Fix ScanCommandConfig property name: Command -> PreScanCommand

ShawkyZ · 2026-01-07T10:56:24Z

Snyk.VisualStudio.Extension.2022/Settings/HtmlSettingsWindow.xaml.cs

+                    {
+                        ThreadHelper.JoinableTaskFactory.Run(async () =>
+                        {
+                            await ThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync();


ShawkyZ · 2026-01-07T10:56:49Z

Snyk.VisualStudio.Extension.2022/Settings/HtmlSettingsWindow.xaml.cs

+                InjectIdeBridgeFunctions();
+
+                // Hide loading label
+                DebugLabel.Visibility = Visibility.Collapsed;


what is DebugLabel ?

ShawkyZ · 2026-01-07T10:57:35Z

Snyk.VisualStudio.Extension.2022/Settings/HtmlSettingsWindow.xaml.cs

+        private async Task<string> GetHtmlContentAsync()
+        {
+            // Try to get HTML from Language Server (with retries)
+            for (int i = 0; i < 3; i++)
+            {
+                try
+                {
+                    var lsHtml = await LanguageServerCommands.GetConfigHtmlAsync(
+                        languageServerRpc,
+                        System.Threading.CancellationToken.None);
+                    if (!string.IsNullOrEmpty(lsHtml))
+                    {
+                        Logger.Information("Successfully loaded settings HTML from Language Server");
+                        return lsHtml;
+                    }
+                    Logger.Warning("Language Server returned empty HTML on attempt {Attempt}", i + 1);
+                }
+                catch (Exception ex)
+                {
+                    Logger.Warning(ex, "Failed to get HTML from Language Server on attempt {Attempt} of 3", i + 1);
+                }
+
+                if (i < 2)
+                    await Task.Delay(1000);
+            }
+
+            // Fall back to embedded HTML
+            Logger.Warning("Falling back to embedded HTML after 3 failed Language Server attempts");
+            return HtmlResourceLoader.LoadFallbackHtml(options);
+        }


why not just check if LangaugeServer is initialized ? If not load fallback

Snyk.VisualStudio.Extension.2022/Settings/IPersistableOption.cs

Snyk.VisualStudio.Extension.2022/Settings/SnykSettings.cs

ShawkyZ · 2026-01-07T11:03:15Z

Snyk.VisualStudio.Extension.2022/UI/Html/ConfigScriptingBridge.cs

+    /// Must be ComVisible for IE11 WebBrowser control's ObjectForScripting.
+    /// </summary>
+    [ComVisible(true)]
+    public class ConfigScriptingBridge


is this only used for the new Html Settings? If yes, please rename it for clarity since the name is too generic

ShawkyZ

please check my comments, happy to pair and go through these changes together.

nick-y-snyk · 2026-01-08T13:18:43Z

Snyk.VisualStudio.Extension.2022/Settings/HtmlSettingsWindow.xaml.cs

+                SetBrowserFeatureControlKey("FEATURE_BROWSER_EMULATION", appName, 11001); // IE11 mode
+                SetBrowserFeatureControlKey("FEATURE_DISABLE_NAVIGATION_SOUNDS", appName, 1);
+                SetBrowserFeatureControlKey("FEATURE_SCRIPTURL_MITIGATION", appName, 1);
+                SetBrowserFeatureControlKey("FEATURE_96DPI_PIXEL", appName, 1); // Force 96 DPI pixel scaling


check for other solutions

ShawkyZ · 2026-01-08T13:19:37Z

Snyk.VisualStudio.Extension.2022/Settings/HtmlSettingsWindow.xaml.cs

+            }
+        }
+
+        private void SetBrowserFeatureControlKey(string feature, string appName, int value)


we must not manipulate the Windows registry

The new page can be enabled (shown on startup) by setting `AutoOpenOnStartup` to `true` and specifying a path for `DEBUG_HTML_FILE_PATH`.

The new settings page is not DPI aware, so I am disabling the flag which falsely says we are. This fixes issues with dropdowns being rendered incorrectly. Also made the debug HTML page actually not supress errors like it says.

feat: initial work

b6ed57a

nick-y-snyk requested review from a team as code owners December 15, 2025 14:33

nick-y-snyk temporarily deployed to snyk-msbuild-envs December 15, 2025 14:33 — with GitHub Actions Inactive

chore: use shared settings-fallback.html and add pipeline job to keep…

3865155

… files in sync

andrewrobinsonhodges-snyk temporarily deployed to snyk-msbuild-envs December 15, 2025 14:41 — with GitHub Actions Inactive

feat: migrate to modal window

3e659ed

nick-y-snyk temporarily deployed to snyk-msbuild-envs December 17, 2025 09:44 — with GitHub Actions Inactive

nick-y-snyk temporarily deployed to snyk-msbuild-envs December 18, 2025 13:25 — with GitHub Actions Inactive

andrewrobinsonhodges-snyk approved these changes Dec 18, 2025

View reviewed changes

nick-y-snyk temporarily deployed to snyk-msbuild-envs December 18, 2025 17:14 — with GitHub Actions Inactive

nick-y-snyk force-pushed the feat/IDE-1458 branch from 3ef86fd to 2fb042e Compare December 18, 2025 17:26

nick-y-snyk temporarily deployed to snyk-msbuild-envs December 18, 2025 17:26 — with GitHub Actions Inactive

nick-y-snyk had a problem deploying to snyk-msbuild-envs December 18, 2025 17:26 — with GitHub Actions Error

nick-y-snyk force-pushed the feat/IDE-1458 branch from 2fb042e to 90a8c80 Compare December 18, 2025 17:27

ShawkyZ reviewed Jan 7, 2026

View reviewed changes

Snyk.VisualStudio.Extension.2022/Settings/IPersistableOption.cs Show resolved Hide resolved

ShawkyZ reviewed Jan 7, 2026

View reviewed changes

Snyk.VisualStudio.Extension.2022/Settings/IPersistableOption.cs Show resolved Hide resolved

ShawkyZ reviewed Jan 7, 2026

View reviewed changes

Snyk.VisualStudio.Extension.2022/Settings/SnykSettings.cs Show resolved Hide resolved

ShawkyZ reviewed Jan 7, 2026

View reviewed changes

ShawkyZ requested changes Jan 7, 2026

View reviewed changes

nick-y-snyk commented Jan 8, 2026

View reviewed changes

ShawkyZ reviewed Jan 8, 2026

View reviewed changes

progress

9232e66

nick-y-snyk temporarily deployed to snyk-msbuild-envs January 8, 2026 17:38 — with GitHub Actions Inactive

fix: back to real settings page

68288be

rrama temporarily deployed to snyk-msbuild-envs January 8, 2026 17:57 — with GitHub Actions Inactive

Merge branch 'main' into feat/IDE-1458

08d9ccd

nick-y-snyk temporarily deployed to snyk-msbuild-envs January 9, 2026 10:34 — with GitHub Actions Inactive

feat: add debug HTML settings page for rapid dev

37bee04

The new page can be enabled (shown on startup) by setting `AutoOpenOnStartup` to `true` and specifying a path for `DEBUG_HTML_FILE_PATH`.

rrama temporarily deployed to snyk-msbuild-envs January 9, 2026 17:17 — with GitHub Actions Inactive

fix: disable false DPI awareness

f178ac2

The new settings page is not DPI aware, so I am disabling the flag which falsely says we are. This fixes issues with dropdowns being rendered incorrectly. Also made the debug HTML page actually not supress errors like it says.

rrama deployed to snyk-msbuild-envs January 9, 2026 18:33 — with GitHub Actions Active

rrama temporarily deployed to snyk-msbuild-envs January 9, 2026 18:33 — with GitHub Actions Inactive

feat: integrate HTML config dialog from Language Server [IDE-1458] #426

Are you sure you want to change the base?

feat: integrate HTML config dialog from Language Server [IDE-1458] #426

Uh oh!

Conversation

nick-y-snyk commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Screenshots / GIFs

Uh oh!

snyk-io bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

nick-y-snyk commented Dec 17, 2025

Uh oh!

andrewrobinsonhodges-snyk Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

andrewrobinsonhodges-snyk Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShawkyZ Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

ShawkyZ Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

ShawkyZ Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShawkyZ Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

ShawkyZ left a comment

Choose a reason for hiding this comment

Uh oh!

nick-y-snyk Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

ShawkyZ Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nick-y-snyk commented Dec 15, 2025 •

edited

Loading

snyk-io bot commented Dec 15, 2025 •

edited

Loading

ShawkyZ Jan 7, 2026 •

edited

Loading