Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Feature/Contacts/ContactsFeature.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
interface ContactsFeature
{
/**
* @param FindContactsBag|null $findContactsBag
* @return Contact[]
* @todo method signature to be changed in next major release as implicitly marking parameter as nullable is deprecated since PHP 8.4
*/
public function findContacts(FindContactsBag $findContactsBag = null): array;
public function findContacts($findContactsBag = null): array;

public function findContact(FindContactBag $findContactBag): Contact;

Expand Down
4 changes: 2 additions & 2 deletions src/Feature/Contacts/ContactsHttpFeature.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ public function __construct(RestRequestExecutor $restRequestExecutor, DataFactor
}

/**
* @todo method signature to be changed in next major release as implicitly marking parameter as nullable is deprecated since PHP 8.4
* @param FindContactsBag|null $findContactsBag
*/
public function findContacts(FindContactsBag $findContactsBag = null): array
public function findContacts($findContactsBag = null): array
{
$result = $this->restRequestExecutor->read('contacts', (array)$findContactsBag);

Expand Down
9 changes: 6 additions & 3 deletions src/Feature/Sms/Bag/ScheduleSmsBag.php
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ public function setParams(array $params): self
}

/**
* @todo method signature to be changed in next major release as implicitly marking parameter as nullable is deprecated since PHP 8.4
* @param bool|null $checkIdx
*/
public function setExternalId(string $idx, bool $checkIdx = null): self
public function setExternalId(string $idx, $checkIdx = null): self
{
$this->idx = [$idx];
$this->checkIdx = $checkIdx;
Expand All @@ -82,7 +82,10 @@ public function setExternalId(string $idx, bool $checkIdx = null): self
* @deprecated
* @see ScheduleSmsBag::setExternalId()
*/
public function setIdx(array $idx, bool $checkIdx = null): self
/**
* @param bool|null $checkIdx
*/
public function setIdx(array $idx, $checkIdx = null): self
{
$this->idx = $idx;
$this->checkIdx = $checkIdx;
Expand Down
9 changes: 6 additions & 3 deletions src/Feature/Sms/Bag/ScheduleSmsToGroupBag.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ public static function withTemplateName(DateTimeInterface $scheduleAt, string $g
}

/**
* @todo method signature to be changed in next major release as implicitly marking parameter as nullable is deprecated since PHP 8.4
* @param bool|null $checkIdx
*/
public function setExternalId(string $idx, bool $checkIdx = null): self
public function setExternalId(string $idx, $checkIdx = null): self
{
$this->idx = [$idx];
$this->checkIdx = $checkIdx;
Expand All @@ -70,7 +70,10 @@ public function setExternalId(string $idx, bool $checkIdx = null): self
* @deprecated
* @see ScheduleSmsToGroupBag::setExternalId()
*/
public function setIdx(array $idx, bool $checkIdx = null): self
/**
* @param bool|null $checkIdx
*/
public function setIdx(array $idx, $checkIdx = null): self
{
$this->idx = $idx;
$this->checkIdx = $checkIdx;
Expand Down
4 changes: 2 additions & 2 deletions src/Feature/Sms/Bag/ScheduleSmssBag.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ public function setParams(array $params): self
}

/**
* @todo method signature to be changed in next major release as implicitly marking parameter as nullable is deprecated since PHP 8.4
* @param bool|null $checkIdx
*/
public function setExternalId(array $idx, bool $checkIdx = null): self
public function setExternalId(array $idx, $checkIdx = null): self
{
$this->idx = $idx;
$this->checkIdx = $checkIdx;
Expand Down
4 changes: 2 additions & 2 deletions src/Feature/Sms/Bag/SendSmsBag.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ public function setParams(array $params): self
}

/**
* @todo method signature to be changed in next major release as implicitly marking parameter as nullable is deprecated since PHP 8.4
* @param bool|null $checkIdx
*/
public function setExternalId(string $idx, bool $checkIdx = null): self
public function setExternalId(string $idx, $checkIdx = null): self
{
$this->idx = [$idx];
$this->checkIdx = $checkIdx;
Expand Down
9 changes: 6 additions & 3 deletions src/Feature/Sms/Bag/SendSmsToGroupBag.php
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ public static function withTemplateName(string $group, string $templateName): se
}

/**
* @todo method signature to be changed in next major release as implicitly marking parameter as nullable is deprecated since PHP 8.4
* @param bool|null $checkIdx
*/
public function setExternalId(string $idx, bool $checkIdx = null): self
public function setExternalId(string $idx, $checkIdx = null): self
{
$this->idx = [$idx];
$this->checkIdx = $checkIdx;
Expand All @@ -63,7 +63,10 @@ public function setExternalId(string $idx, bool $checkIdx = null): self
* @deprecated
* @see SendSmsToGroupBag::setExternalId()
*/
public function setIdx(array $idx, bool $checkIdx = null): self
/**
* @param bool|null $checkIdx
*/
public function setIdx(array $idx, $checkIdx = null): self
{
$this->idx = $idx;
$this->checkIdx = $checkIdx;
Expand Down
4 changes: 2 additions & 2 deletions src/Feature/Sms/Bag/SendSmssBag.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ public function setParams(array $params): self
}

/**
* @todo method signature to be changed in next major release as implicitly marking parameter as nullable is deprecated since PHP 8.4
* @param bool|null $checkIdx
*/
public function setExternalId(array $idx, bool $checkIdx = null): self
public function setExternalId(array $idx, $checkIdx = null): self
{
$this->idx = $idx;
$this->checkIdx = $checkIdx;
Expand Down
Loading