smithy-http: disable redirects in aiohttp client - #764
Open
arandito wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR disables automatic HTTP redirect following in the aiohttp client by passing
allow_redirects=Falsetoself._session.request(...). This ensures that 3xx responses are returned to the caller instead of being followed by the transport.This aligns the aiohttp transport with SDK convention of not following redirects by default (e.g. botocore via
Retry(False), and smithy-kotlin via OkHttpfollowRedirects(false)). The CRT transport is not updated because the CRT client already does not follow redirects (no behavior or option exists).Testing
make check-pyandmake test-pypass (1793 passed, 9 skipped).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.