Conversation
…g resolution (#640) * Add config source interface and environment variable source
* Add a ConfigResolver that goes through the list of sources to resolve config value
…idators (#642) * Add a config property descriptor along with a custom resolver and validators
…solution. (#646) * Update the codegen files that generate config.py to support config resolution.
* Replace raw source strings with typed SourceInfo dataclasses
* Add support for sdk_ua_app_id
| .nullable(false) | ||
| .initialize(writer -> writer.write("self.interceptors = interceptors or []")) | ||
| .build(), | ||
| ConfigProperty.builder() |
There was a problem hiding this comment.
This diff is a little odd; I would expect no diff in this directory at all (or the parent one). Can you reset this to what's in develop?
I don't think there are any changes here?
| } | ||
|
|
||
| /** | ||
| * @return Returns the validator symbol for this property, if any. |
There was a problem hiding this comment.
Shouldn't these changes be in the AWS file directory and be added as a hook or similar? I'd expect this code to live alongside AWSConfiguration, etc. since this is AWS specific?
For instance, you can't use defaultValue for a generic SDK, or a descriptor, or anything and expect it to work.
| This descriptor handles: | ||
| - Lazy resolution from sources (only on first access) | ||
| - Custom resolution for variables requiring complex resolution | ||
| - Caching of resolved values |
There was a problem hiding this comment.
It only handles the cache key and retrieval of the cached value, right? It doesn't store the cached values itself (though maybe it should?)
| {"retry_mode": "environment", "max_attempts": "default"} | ||
| """ | ||
|
|
||
| retry_mode, mode_source = resolver.get("retry_mode") |
There was a problem hiding this comment.
For a future PR, I think I may want to see some of this restructured. How would you feel about (in the future) having the resolver accept a ConfigProperty object. The ConfigProperty could hold its own overrides, so it would know how to fetch itself from each source when non-default.
There's a lot of complex tradeoffs here that cause conflicting requirements
2 participants
Issue #, if available:
Description of changes:
This PR implements the following:
retry_strategy,regionandsdk_ua_app_id(in progress)Tests
Note: There are 2 minor PRs yet to be merged.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.