Optimize CBOR Codec#1183
Merged
Merged
Conversation
mtdowling
requested changes
May 18, 2026
rhernandez35
previously requested changes
May 18, 2026
| * <ol> | ||
| * <li><b>Speculative fast path</b>: check the expected next member via length + Arrays.equals | ||
| * (JVM-intrinsified). Fires on every field when CBOR map entries arrive in schema definition | ||
| * order (the common case for smithy-to-smithy communication). |
Collaborator
There was a problem hiding this comment.
I avoided doing this originally because I didn't want adding new fields to have visible performance effects, especially to legacy clients. Adding a new optional field or reordering schema fields should not have a visible performance effect.
Collaborator
|
Please do some perf testing with clients that have out-of-date schemas and servers that are receiving unknown fields. I'm concerned about adverse impact outside of all but the happiest cases in this PR. |
2ac8255 to
db811fa
Compare
mtdowling
approved these changes
May 19, 2026
db811fa to
d6f3ecd
Compare
The previous readTimestamp passed the tagged token to readLong, which always threw SerializationException before reaching Instant.ofEpochSecond, masking the fact that out-of-range epoch values cause DateTimeException. Now that the token is correctly stripped, wrap with try-catch to convert the overflow to SerializationException (zero happy-path cost via exception tables).
d6f3ecd to
0a6d2ef
Compare
Primary concern addressed, got 1 approval if there are more concerns we can address in a followup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.