WIP: String streaming (w/ separate JSON string reader cls)#91
Open
smheidrich wants to merge 2 commits intomainfrom
Open
WIP: String streaming (w/ separate JSON string reader cls)#91smheidrich wants to merge 2 commits intomainfrom
smheidrich wants to merge 2 commits intomainfrom
Conversation
This was referenced Aug 22, 2023
8fa2f9d to
0125b92
Compare
Allows json-stream's JsonStringReader unit tests to work for us, too.
0125b92 to
ec680c9
Compare
Owner
Author
|
@daggaz Just to let you know: I think the most important features here are finally ready (namely, returning strings as objects that can be So I'm prepared to merge this when you are 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2nd attempt at something that looks more like how it's done in json-stream, i.e. with a separate JSON string reader class.
Equivalent of daggaz/json-stream#47 on json-stream side.
Supersedes #84 and #89.
ToDos:
RustTokenizerJsonStringReaderimpl.read__next__readlinecompletedor sth.readreturning an empty string should be indication that it's done enough.*IOBase?