Skip to content

fix: unused varibles in vfs #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreCostaaa merged 2 commits into from
Apr 1, 2025
Merged

fix: unused varibles in vfs #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4760378
fix(vfs): init vars so they aren't used uninitialized
AndreCostaaa Mar 30, 2025
acfeaf7
refactor(vfs): rename attribute to gfd for explicitness
AndreCostaaa Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions so3/fs/vfs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ int vfs_set_open_mode(int gfd, uint32_t flags_open_mode)

uint32_t vfs_get_access_mode(int gfd)
{
uint32_t ret;
uint32_t ret = 0;

mutex_lock(&vfs_lock);

Expand All @@ -314,7 +314,7 @@ void vfs_set_access_mode(int gfd, uint32_t flags_access_mode)

uint32_t vfs_get_operating_mode(int gfd)
{
uint32_t ret;
uint32_t ret = 0;
mutex_lock(&vfs_lock);

if (open_fds[gfd])
Expand Down
6 changes: 3 additions & 3 deletions so3/include/vfs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,9 @@ void vfs_set_priv(int gfd, void *data);
void *vfs_get_priv(int gfd);
int vfs_clone_fd(int *gfd_src, int *gfd_dst);

uint32_t vfs_get_access_mode(int fd);
uint32_t vfs_get_open_mode(int fd);
uint32_t vfs_get_operating_mode(int fd);
uint32_t vfs_get_access_mode(int gfd);
uint32_t vfs_get_open_mode(int gfd);
uint32_t vfs_get_operating_mode(int gfd);

void vfs_set_access_mode(int gfd, uint32_t flags_access_mode);
int vfs_set_open_mode(int gfd, uint32_t flags_open_mode);
Expand Down