feat: use new init commands feature for lvperf images#143
Merged
AndreCostaaa merged 2 commits intomainfrom Apr 1, 2025
Merged
Conversation
Contributor
|
That's great! I would propose a small change: would it be possible to rename init_commands.txt by commands.ini ? And thus reserving .ini extension for this application? (or even .cfg) |
Contributor
Author
|
I like |
daniel-rossier
approved these changes
Apr 1, 2025
AndreCostaaa
force-pushed
the
140-feat-use-new-init-program-in-lv_perf-configs
branch
2 times, most recently
from
fb76d88 to
66bf210
Compare
daniel-rossier
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the new init_commands feature in the lvperf images.
I patched the config inside the Dockerfile instead of modifying it directly because when running the config locally,
lvgl_benchmarkshould still be executed by default.For the image, I'm using the new
init_commandsfeature, making it easy to mount other init commands if I need to run different applicationsNote that the
init_commandsfeature is currently broken on aarch64 (see #141), so this PR depends on #142 being merged for it to work properly