fix: second-page always flip after first looping#257
Open
PhyoThihaWin wants to merge 3 commits intosmarteist:masterfrom
Open
fix: second-page always flip after first looping#257PhyoThihaWin wants to merge 3 commits intosmarteist:masterfrom
PhyoThihaWin wants to merge 3 commits intosmarteist:masterfrom
Conversation
PhyoThihaWin
commented
Sep 23, 2023
PhyoThihaWin
commented
- Change the flip issue position to last page.
- But still flip animation obviously and not good at UX,
- Disable smoothScroll at LastPage->FirstPage.
- so increase currentPosition continuously and never reset - AUTO_CYCLE_DIRECTION_BACK_AND_FORTH is different from LEFT and RIGHT
- so increase currentPosition continuously and never reset - AUTO_CYCLE_DIRECTION_BACK_AND_FORTH is different from LEFT and RIGHT
shubhamdevgupta
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.