Refactor secret handling to use byte arrays for values#444
Draft
anirudhwarrier wants to merge 1 commit into
Draft
Refactor secret handling to use byte arrays for values#444anirudhwarrier wants to merge 1 commit into
anirudhwarrier wants to merge 1 commit into
Conversation
- Updated SecretItem struct to store secret values as byte arrays instead of strings. - Introduced ZeroUpsertSecretValues function to clear secret values from memory after use. - Modified EncryptSecret and encryptSecretWithLabel functions to accept byte arrays. - Updated tests to reflect changes in secret value type and ensure proper functionality. - Added memory safety measures in various handler methods to prevent sensitive data leakage.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the secrets CLI flow to hold secret payloads as []byte and proactively zero secret material after use to reduce the risk of sensitive data lingering in memory.
Changes:
- Changed
SecretItem.Valuefromstringto[]byteand updated encryption helpers to accept byte slices. - Added
ZeroUpsertSecretValuesand applied it (viadefer) across create/update and browser flows. - Updated tests to use
[]bytesecret values.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/secrets/update/update.go | Defers zeroing of resolved secret values for update flow. |
| cmd/secrets/create/create.go | Defers zeroing of resolved secret values for create flow. |
| cmd/secrets/common/handler.go | Switches secret value type to []byte, adds zeroing helper, updates encryption and adds additional in-flow wiping. |
| cmd/secrets/common/handler_test.go | Updates test inputs to use []byte values. |
| cmd/secrets/common/browser_flow.go | Adds deferred zeroing for browser upsert flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
163
to
174
| envVal, ok := os.LookupEnv(envName) | ||
| if !ok { | ||
| return nil, fmt.Errorf("environment variable %q for secret %q not found; please export it", envName, id) | ||
| } | ||
| if !utf8.ValidString(envVal) { | ||
| if !utf8.Valid([]byte(envVal)) { | ||
| return nil, fmt.Errorf("value for secret %q (env %q) contains invalid UTF-8", id, envName) | ||
| } | ||
|
|
||
| out = append(out, SecretItem{ | ||
| ID: id, | ||
| Value: envVal, | ||
| Value: []byte(envVal), | ||
| Namespace: "main", |
Comment on lines
340
to
345
| encryptedSecrets := make([]*vault.EncryptedSecret, 0, len(rawSecrets)) | ||
| for _, item := range rawSecrets { | ||
| for i := range rawSecrets { | ||
| item := &rawSecrets[i] | ||
| cipherHex, err := EncryptSecret(item.Value, pubKeyHex, h.OwnerAddress) | ||
| clear(item.Value) | ||
| if err != nil { |
Comment on lines
+66
to
+67
| defer ZeroUpsertSecretValues(inputs) | ||
|
|
Comment on lines
250
to
252
| raw := UpsertSecretsInputs{ | ||
| {ID: "secret-1", Value: "val1", Namespace: "main"}, | ||
| {ID: "secret-1", Value: []byte("val1"), Namespace: "main"}, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVSVCS-4954