feat: add refactored set config changeset,sequences and ops#90
Draft
ecPablo wants to merge 10 commits into
Draft
feat: add refactored set config changeset,sequences and ops#90ecPablo wants to merge 10 commits into
ecPablo wants to merge 10 commits into
Conversation
Release impact (release-please)
PR title: Merging this PR as-is will contribute a minor bump to the next release-please release PR. Conventional commit → bump
Update the PR title before merge if you need a different bump (squash commit message = PR title). Preview is based on this PR title only. The release-please release PR may include other unreleased commits already on |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pablo Estrada <139084212+ecPablo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after: #89
Adds the refactored set config changeset, leveragin the new cldf utils for changeset contruction and similar code structure to the the PR for deploy in #89. Main design changes are:
MCMSReaderinterfaces which has a separate implementation per chain.AI Summary
This pull request introduces a new "set-config" changeset for MCMS (Multi-Chain Multisig) contract configuration, adding a modular, family-agnostic system for setting contract config via references rather than addresses. It also includes supporting helpers, type definitions, and a registry for chain family-specific implementations. Additionally, the PR updates several dependencies in
go.modto newer versions.The most important changes are:
New MCMS Set-Config Changeset System:
mcms/changesets/set-config/changeset.go, implementing a new changeset for setting MCMS contract configurations using contract references, with support for MCMS timelock proposals and per-chain grouping.mcms/changesets/set-config/types.go, defining core types such asContractSetConfig,ChainInput,ChainOutput, and theSequenceinterface for family-specific logic.mcms/changesets/set-config/registry.go, providing a registry for registering and retrieving chain family-specific set-config sequence implementations, supporting modular extension.Supporting Utilities and Tests:
mcms/changesets/set-config/helpers_test.gofor constructing test inputs, deploying and transferring MCMS contracts, and validating EVM/MCMS integration.datastore/refkey/refkey.go, a utility for referencing contracts in the environment datastore by chain, type, version, and qualifier, enabling address-agnostic contract identification.Dependency Updates:
go.modto newer versions of several dependencies, includingchainlink-deployments-framework,mcms, AWS SDK packages, and others, and adds new indirect dependencies such aschainlink-cantonandgo-daml. [1] [2] [3] [4] [5]