[CRE-4955] Add sharding test with EVM logtrigger acks. - #23278
Open
pavel-raykov wants to merge 4 commits into
Open
[CRE-4955] Add sharding test with EVM logtrigger acks.#23278pavel-raykov wants to merge 4 commits into
pavel-raykov wants to merge 4 commits into
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
pavel-raykov
force-pushed
the
test-shard-ack
branch
from
July 30, 2026 11:38
77e66f8 to
cabd8df
Compare
pavel-raykov
changed the title
pavel-raykov
force-pushed
the
test-shard-ack
branch
from
July 30, 2026 12:20
2f8ec42 to
3db410a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM — system/smoke test behavior is expanded (additional subtest) and now relies on background EVM event emission + ACK log scanning, which can affect test stability and runtime.
Purpose: Extend the CRE sharding smoke test to exercise sharding with an EVM LogTrigger workflow (and verify trigger ACKs), alongside the existing cron-trigger workflow path.
Changes:
- Split sharding coverage into two subtests: cron-trigger and EVM LogTrigger-triggered sharding, with ACK verification for the latter.
- Parameterized the expected user-log substring used to detect workflow executions (instead of hardcoding the cron log message).
- Refactored EVM log trigger event emission into shared helpers for reuse across tests.
Areas needing scrupulous human review:
- The background event emission goroutine lifecycle/cancellation semantics and its interaction with test teardown/timeouts.
- The reuse of a shared sharding test environment across sequential subtests and any state caching that may still leak across runs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| system-tests/tests/smoke/cre/sharding_test.go | Adds cron + EVM LogTrigger sharding variants and makes execution detection depend on a passed-in expected log substring. |
| system-tests/tests/smoke/cre/evm_capability_test.go | Uses the shared EVM log trigger event emitter helper instead of inline ticker logic. |
| system-tests/tests/smoke/cre/cre_suite_test.go | Runs sharding as two subtests and resets OperationsBundle between them to avoid cached changeset behavior. |
| system-tests/tests/smoke/cre/capability_helpers.go | Introduces shared helpers for EVM log trigger background event emission and event submission. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.