Streamline Dev Dependencies#22811
Draft
kalverra wants to merge 6 commits into
Draft
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Summary
Centralizes dev-tool version pinning behind two manifest files and a Go CLI (
tools/toolversion). Replaces scattered hardcoded pins in the Makefile, CI, scripts, and Docker with manifest lookups, and adds a drift checker so version bumps happen in one place.Why
Dev-tool versions were drifting across
GNUmakefile, nested.tool-versionsfiles, CI actions, and shell scripts (e.g. golangci-lint2.11.4in CI vs2.12.2in.tool-versions, gotestsum1.12.3vs1.13.0).What changed
tools/toolversion/— reads manifests, installs tools, checks drift.tool-versions— mise/asdf runtimes (go, node, mockery, protoc, golangci-lint, …)tools/go-tools.txt— purego installCLIs (gomods, gotestsum, delve, …)go run ./tools/toolversioninstead of hardcoding@vX.Y.Z.tool-versionsremoved — integration-tests and cre/environment copies merged into roottools/bin/tool-version,check-tool-versions,tool-version_test.shmake test-tool-versions+make check-tool-versionsin the generate/clean jobHow it works
Bump a version: edit one line in the right manifest, run
make check-tool-versions..tool-versionsmockery 2.53.0go installCLI, no plugintools/go-tools.txtgotest.tools/gotestsum 1.13.0Install tools (any dev, no version manager required):
make install-dev-tools # mockery, gomods, modgraph, codecgen, gencodec + protoc pluginsWith mise/asdf:
mise install/asdf installfor runtimes, thenmake install-dev-toolsfor Go CLIs.Makefile / CI read versions at runtime:
Drift guard (
toolversion check):go install …@pinin tracked source (Makefile, workflows, scripts, …).tool-versionsgolangmatches rootgo.modgodirective.tool-versions(repo root)tools/version-exceptions.yaml(protoc plugins coupled togo.mod)Intentional exceptions
go.modgodirective — authoritative for the module toolchain;.tool-versionsgolang mirrors itgo.moddeps, not manifests