Skip to content

fix accept ownership bug #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FelixFan1992 wants to merge 2 commits into from
Closed

fix accept ownership bug #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6c8694
fix accept ownership bug
FelixFan1992 Jan 30, 2026
12b15c5
update
FelixFan1992 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions deployment/ops/ccip_burn_mint_token_pool/op_deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ var TransferOwnershipBurnMintTokenPoolOp = cld_ops.NewOperation(
type AcceptOwnershipBurnMintTokenPoolInput struct {
BurnMintTokenPoolPackageId string
TypeArgs []string
StateObjectId string
MCMSRegistryObjectId string
}

type AcceptOwnershipBurnMintTokenPoolObjects struct {
Expand All @@ -131,11 +131,11 @@ var acceptOwnershipBurnMintTokenPoolHandler = func(b cld_ops.Bundle, deps sui_op
return sui_ops.OpTxResult[AcceptOwnershipBurnMintTokenPoolObjects]{}, err
}

encodedCall, err := burnMintTokenPoolPackage.Encoder().AcceptOwnership(input.TypeArgs, bind.Object{Id: input.StateObjectId})
encodedCall, err := burnMintTokenPoolPackage.Encoder().AcceptOwnership(input.TypeArgs, bind.Object{Id: input.MCMSRegistryObjectId})
if err != nil {
return sui_ops.OpTxResult[AcceptOwnershipBurnMintTokenPoolObjects]{}, fmt.Errorf("failed to encode AcceptOwnership call: %w", err)
}
call, err := sui_ops.ToTransactionCallWithTypeArgs(encodedCall, input.StateObjectId, input.TypeArgs)
call, err := sui_ops.ToTransactionCallWithTypeArgs(encodedCall, input.MCMSRegistryObjectId, input.TypeArgs)
if err != nil {
return sui_ops.OpTxResult[AcceptOwnershipBurnMintTokenPoolObjects]{}, fmt.Errorf("failed to convert encoded call to TransactionCall: %w", err)
}
Expand Down
6 changes: 3 additions & 3 deletions deployment/ops/ccip_lock_release_token_pool/op_deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ var TransferOwnershipLockReleaseTokenPoolOp = cld_ops.NewOperation(
type AcceptOwnershipLockReleaseTokenPoolInput struct {
LockReleaseTokenPoolPackageId string
TypeArgs []string
StateObjectId string
MCMSRegistryObjectId string
}

type AcceptOwnershipLockReleaseTokenPoolObjects struct {
Expand All @@ -131,11 +131,11 @@ var acceptOwnershipLockReleaseTokenPoolHandler = func(b cld_ops.Bundle, deps sui
return sui_ops.OpTxResult[AcceptOwnershipLockReleaseTokenPoolObjects]{}, err
}

encodedCall, err := lockReleaseTokenPoolPackage.Encoder().AcceptOwnership(input.TypeArgs, bind.Object{Id: input.StateObjectId})
encodedCall, err := lockReleaseTokenPoolPackage.Encoder().AcceptOwnership(input.TypeArgs, bind.Object{Id: input.MCMSRegistryObjectId})
if err != nil {
return sui_ops.OpTxResult[AcceptOwnershipLockReleaseTokenPoolObjects]{}, fmt.Errorf("failed to encode AcceptOwnership call: %w", err)
}
call, err := sui_ops.ToTransactionCallWithTypeArgs(encodedCall, input.StateObjectId, input.TypeArgs)
call, err := sui_ops.ToTransactionCallWithTypeArgs(encodedCall, input.MCMSRegistryObjectId, input.TypeArgs)
if err != nil {
return sui_ops.OpTxResult[AcceptOwnershipLockReleaseTokenPoolObjects]{}, fmt.Errorf("failed to convert encoded call to TransactionCall: %w", err)
}
Expand Down
6 changes: 3 additions & 3 deletions deployment/ops/ccip_managed_token_pool/op_deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ var TransferOwnershipManagedTokenPoolOp = cld_ops.NewOperation(
type AcceptOwnershipManagedTokenPoolInput struct {
ManagedTokenPoolPackageId string
TypeArgs []string
StateObjectId string
MCMSRegistryObjectId string
}

type AcceptOwnershipManagedTokenPoolObjects struct {
Expand All @@ -133,11 +133,11 @@ var acceptOwnershipManagedTokenPoolHandler = func(b cld_ops.Bundle, deps sui_ops
return sui_ops.OpTxResult[AcceptOwnershipManagedTokenPoolObjects]{}, err
}

encodedCall, err := managedTokenPoolPackage.Encoder().AcceptOwnership(input.TypeArgs, bind.Object{Id: input.StateObjectId})
encodedCall, err := managedTokenPoolPackage.Encoder().AcceptOwnership(input.TypeArgs, bind.Object{Id: input.MCMSRegistryObjectId})
if err != nil {
return sui_ops.OpTxResult[AcceptOwnershipManagedTokenPoolObjects]{}, fmt.Errorf("failed to encode AcceptOwnership call: %w", err)
}
call, err := sui_ops.ToTransactionCallWithTypeArgs(encodedCall, input.StateObjectId, input.TypeArgs)
call, err := sui_ops.ToTransactionCallWithTypeArgs(encodedCall, input.MCMSRegistryObjectId, input.TypeArgs)
if err != nil {
return sui_ops.OpTxResult[AcceptOwnershipManagedTokenPoolObjects]{}, fmt.Errorf("failed to convert encoded call to TransactionCall: %w", err)
}
Expand Down
6 changes: 3 additions & 3 deletions integration-tests/mcms/token_pool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,17 +291,17 @@ func RunOwnershipTokenPoolProposal(s *TokenPoolTestSuite) {
lockreleasetokenpoolops.AcceptOwnershipLockReleaseTokenPoolInput{
LockReleaseTokenPoolPackageId: s.lnrPackageId,
TypeArgs: []string{fmt.Sprintf("%s::link::LINK", s.lnrTokenPackageId)},
StateObjectId: s.lnrObjects.StateObjectId,
MCMSRegistryObjectId: s.registryObj,
},
burnminttokenpoolops.AcceptOwnershipBurnMintTokenPoolInput{
BurnMintTokenPoolPackageId: s.bnmPackageId,
TypeArgs: []string{fmt.Sprintf("%s::link::LINK", s.linkPackageId)},
StateObjectId: s.bnmObjects.StateObjectId,
MCMSRegistryObjectId: s.registryObj,
},
managedtokenpoolops.AcceptOwnershipManagedTokenPoolInput{
ManagedTokenPoolPackageId: s.managedTokenPoolPackageId,
TypeArgs: []string{fmt.Sprintf("%s::link::LINK", s.managedTokenLinkPackageId)},
StateObjectId: s.managedTokenPoolObjects.StateObjectId,
MCMSRegistryObjectId: s.registryObj,
},
},

Expand Down
Loading