Ton analyzer #629

huangzhen1997 · 2025-12-10T03:08:10Z

changeset-bot · 2025-12-10T03:08:13Z

🦋 Changeset detected

Latest commit: 0e98af6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
chainlink-deployments-framework	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull request overview

This PR adds TON blockchain analyzer support to the chainlink-deployments-framework. The implementation follows existing patterns for other chain families (Aptos, Sui, Solana) by integrating TON-specific MCMS SDK functionality.

Key changes:

Added TON transaction analysis capabilities with decoder integration
Updated dependency versions including Go runtime, MCMS SDK, and various libraries
Refactored transaction encoding logic to use family-based routing

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File	Description
go.mod	Updated Go version to 1.25.3 and bumped various dependencies including MCMS SDK, TON utilities, and added chainlink-ton package
experimental/analyzer/upf/upf.go	Integrated TON family support in UPF decoding with mcmstonsdk decoder and simplified encoding logic
experimental/analyzer/ton_analyzer.go	New file implementing TON transaction analysis functions mirroring Sui/Aptos patterns
experimental/analyzer/report_builder.go	Added TON family handling in proposal and timelock report builders

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/analyzer/ton_analyzer.go

experimental/analyzer/upf/upf.go

experimental/analyzer/report_builder_test.go

experimental/analyzer/ton_analyzer.go

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/analyzer/upf/upf_test.go

experimental/analyzer/ton_analyzer_test.go

krebernisak · 2025-12-15T13:12:27Z

experimental/analyzer/upf/upf.go

+
+	// Sui: mcms::timelock_schedule_batch, mcms::timelock_bypasser_execute_batch
+	// Aptos: package::module::timelock_schedule_batch, package::module::timelock_bypasser_execute_batch
+	// TON: ContractType::ScheduleBatch(0x...), ContractType::BypasserExecuteBatch(0x...)


WIll TON type will be provided like this? (e.g., "com.chainlink.ton.lib.access.RBAC::GrantRole(0x0)")

I didn't check the contract type, because with the timelock converter it would be converted to RBACTimelock::ScheduleBatch(0x0)

experimental/analyzer/upf/upf.go

experimental/analyzer/upf/upf_test.go

experimental/analyzer/report_builder_test.go

krebernisak · 2025-12-15T13:24:42Z

experimental/analyzer/report_builder_test.go

+			name:        "TON_decode_failure",
+			selector:    chainsel.TON_TESTNET.Selector,
+			expectedMsg: "failed to decode TON transaction",
+			wantErr:     false, // TON doesn't unmarshal AdditionalFields, so decode errors go to Method field


Hmm, not sure why is here a difference for TON? There shouldn't be one...

Doesn't SUI impl also surfaces errors via .Method member:

chainlink-deployments-framework/experimental/analyzer/sui_analyzer.go

Line 39 in c56332e

Method: errStr.Error(),

This test is for default unhappy pass, where the analyze function suppose to fail immediately. Unlike SUI we don't need extra field Unmarshal, so the first error will be hiding in Method field.

Ok, but what's the reason for diverge in this and other tests?

Where other analyzers fail, TON doesn't - why do we need to catch this error specifically for TON?

The TON analyzer diverges from other analyzers because it reaches the decode stage, whereas EVM and Solana fail earlier due to missing registry, and Aptos and
Sui fail during additional field decoding. TON handles decode failures gracefully by placing the error in the method field rather than returning an error.

For better readability and more context there, I split the TON case into a separate test with comments explaining this distinction.

experimental/analyzer/report_builder_test.go

experimental/analyzer/ton_analyzer_test.go

krebernisak · 2025-12-15T13:41:50Z

experimental/analyzer/report_builder_test.go

+			name:        "TON_decode_failure",
+			selector:    chainsel.TON_TESTNET.Selector,
+			expectedMsg: "failed to decode TON transaction",
+			wantErr:     false, // TON doesn't unmarshal AdditionalFields, so decode errors go to Method field


Shouldn't diverge from other test cases

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

experimental/analyzer/upf/upf.go

experimental/analyzer/upf/upf_test.go

experimental/analyzer/upf/upf.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

krebernisak · 2026-01-27T10:51:44Z

experimental/analyzer/report_builder.go

+			if err != nil {
+				return nil, err
+			}
+			for j := range dec {


nit: This is repeated N times in this file, feels like we should extract it out and simplify at one point:

for j := range dec { ops[j] = OperationReport{ ChainSelector: chainSel, ChainName: chainNameOrUnknown(chainName), Family: family, Calls: []*DecodedCall{dec[j]}, } }

krebernisak · 2026-01-27T11:00:36Z

experimental/analyzer/report_builder_test.go

+			name:        "TON_decode_failure",
+			selector:    chainsel.TON_TESTNET.Selector,
+			expectedMsg: "failed to decode TON transaction",
+			wantErr:     false, // TON doesn't unmarshal AdditionalFields, so decode errors go to Method field


Ok, but what's the reason for diverge in this and other tests?

Where other analyzers fail, TON doesn't - why do we need to catch this error specifically for TON?

krebernisak · 2026-01-27T11:12:09Z

experimental/analyzer/ton_analyzer_test.go

+	exampleRoleBig, _ := cell.BeginCell().
+		MustStoreBigInt(new(big.Int).SetBytes(exampleRole[:]), 257).
+		EndCell().
+		ToBuilder().
+		ToSlice().
+		LoadBigInt(256)


Not sure this is needed as you can just use tlbe.NewUint256(new(big.Int).SetBytes(role[:]))?

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cl-sonarqube-production · 2026-01-29T17:18:51Z

Quality Gate passed

Issues
0 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

support ton analyzer, need testing

e0f9aab

Copilot AI review requested due to automatic review settings December 10, 2025 03:08

huangzhen1997 requested a review from a team as a code owner December 10, 2025 03:08

huangzhen1997 marked this pull request as draft December 10, 2025 03:08

Copilot AI reviewed Dec 10, 2025

View reviewed changes

experimental/analyzer/ton_analyzer.go Outdated Show resolved Hide resolved

experimental/analyzer/ton_analyzer.go Outdated Show resolved Hide resolved

fix typo

a51337a

smartcontractkit deleted a comment from github-actions bot Dec 10, 2025

huangzhen1997 added 2 commits December 9, 2025 21:22

mod tidy

09fc3c2

update test

fe17bf1

krebernisak reviewed Dec 10, 2025

View reviewed changes

huangzhen1997 added 5 commits December 10, 2025 13:23

simplify analyze function

a7aa1a2

refactor

d6f8113

fix lint

d33bd19

Merge branch 'main' into NONEVM-3070/support-ton-analyzer

751007d

add test coverage

c6e01f1

huangzhen1997 requested review from Copilot and krebernisak December 12, 2025 02:01

huangzhen1997 marked this pull request as ready for review December 12, 2025 02:01

Copilot AI reviewed Dec 12, 2025

View reviewed changes

huangzhen1997 added 2 commits December 11, 2025 21:06

lint

93c385e

add test

a840aea

Copilot AI review requested due to automatic review settings December 12, 2025 04:00

Copilot AI reviewed Dec 12, 2025

View reviewed changes

fix lint

c56332e

huangzhen1997 requested a review from Copilot December 12, 2025 04:25

Copilot AI reviewed Dec 12, 2025

View reviewed changes

experimental/analyzer/upf/upf_test.go Outdated Show resolved Hide resolved

experimental/analyzer/ton_analyzer_test.go Outdated Show resolved Hide resolved

huangzhen1997 requested a review from ecPablo December 12, 2025 15:22

krebernisak reviewed Dec 15, 2025

View reviewed changes

Merge branch 'main' into NONEVM-3070/support-ton-analyzer

7294c52

Copilot AI reviewed Jan 22, 2026

View reviewed changes

experimental/analyzer/upf/upf.go Outdated Show resolved Hide resolved

experimental/analyzer/upf/upf_test.go Outdated Show resolved Hide resolved

experimental/analyzer/upf/upf.go Outdated Show resolved Hide resolved

huangzhen1997 and others added 2 commits January 21, 2026 20:35

fix go mod and update registry

4d80162

Update experimental/analyzer/upf/upf_test.go

a005805

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 22, 2026 02:36

Copilot AI reviewed Jan 22, 2026

View reviewed changes

fix test and refactor timelock checker

c3530bf

huangzhen1997 requested review from ecPablo and krebernisak January 22, 2026 02:56

fix lint

46fb259

Copilot AI review requested due to automatic review settings January 22, 2026 03:01

Copilot AI reviewed Jan 22, 2026

View reviewed changes

huangzhen1997 added 2 commits January 22, 2026 16:04

Merge branch 'main' into NONEVM-3070/support-ton-analyzer

bd55ade

Merge branch 'main' into NONEVM-3070/support-ton-analyzer

d7cf8ae

Copilot AI review requested due to automatic review settings January 27, 2026 04:26

Copilot AI reviewed Jan 27, 2026

View reviewed changes

krebernisak reviewed Jan 27, 2026

View reviewed changes

huangzhen1997 added 2 commits January 27, 2026 10:53

address comment

c2b5193

Merge branch 'main' into NONEVM-3070/support-ton-analyzer

b23b872

Copilot AI review requested due to automatic review settings January 27, 2026 16:54

Copilot AI reviewed Jan 27, 2026

View reviewed changes

huangzhen1997 added 2 commits January 27, 2026 13:54

update

cb31ba4

Merge branch 'main' into NONEVM-3070/support-ton-analyzer

4601b1a

huangzhen1997 requested review from Copilot and krebernisak January 27, 2026 19:55

Copilot AI reviewed Jan 27, 2026

View reviewed changes

huangzhen1997 added 2 commits January 29, 2026 09:55

bump mcms version

1b01990

fix broken test

0e98af6

Copilot AI review requested due to automatic review settings January 29, 2026 17:09

Copilot AI reviewed Jan 29, 2026

View reviewed changes

Ton analyzer #629

Are you sure you want to change the base?

Ton analyzer #629

Uh oh!

Conversation

huangzhen1997 commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

huangzhen1997 commented Dec 10, 2025 •

edited

Loading

changeset-bot bot commented Dec 10, 2025 •

edited

Loading

huangzhen1997 Dec 15, 2025 •

edited

Loading

huangzhen1997 Dec 16, 2025 •

edited

Loading

huangzhen1997 Jan 27, 2026 •

edited

Loading