Build external repos with keystore - #2255
Conversation
7d3ddf4 to
2ba6608
Compare
2ba6608 to
5bb65fc
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the “Build External Repositories” GitHub Actions workflow to use a shared ref-parsing script hosted in smartcontractkit/.github, and tightens the external build check by also bumping the chainlink-common/keystore module when building Chainlink Core.
Changes:
- Switch
build_external.ymlto checkout and executeget-refs-from-pr-body.jsfromsmartcontractkit/.github(sparse checkout intodot_github/). - Add an explicit
go getforgithub.com/smartcontractkit/chainlink-common/keystore@${COMMON_SHA}when building/chainlink. - Remove the local
.github/scripts/get-refs-from-pr-body.jsscript from this repo (now sourced externally).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/build_external.yml | Uses shared script from smartcontractkit/.github and bumps chainlink-common/keystore in the Chainlink build step. |
| .github/scripts/get-refs-from-pr-body.js | Removes the local script implementation (relocated to shared org .github repo). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| repository: smartcontractkit/.github | ||
| # TODO: pin to a commit SHA once the get-refs-from-pr-body.js PR is merged into smartcontractkit/.github. | ||
| ref: feature/get-ref-from-pr-body | ||
| persist-credentials: false | ||
| sparse-checkout: tools/scripts/get-refs-from-pr-body.js |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 64a24c5 | Previous: 7d3ddf4 | Ratio |
|---|---|---|---|
BenchmarkKeystore_Sign/nop/in-process |
758.2 ns/op |
278.9 ns/op |
2.72 |
This comment was automatically generated by workflow using github-action-benchmark.
get ref from prto .github repo to be shared with other repos.