Skip to content

Build external repos with keystore - #2255

Open
dhaidashenko wants to merge 5 commits into
mainfrom
feature/build-external-with-keystore
Open

Build external repos with keystore#2255
dhaidashenko wants to merge 5 commits into
mainfrom
feature/build-external-with-keystore

Conversation

@dhaidashenko

@dhaidashenko dhaidashenko commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
  • Move get ref from pr to .github repo to be shared with other repos.
  • Add keystore bump to the chainlink build to catch breaking changes

@dhaidashenko
dhaidashenko force-pushed the feature/build-external-with-keystore branch from 7d3ddf4 to 2ba6608 Compare July 15, 2026 18:16
@dhaidashenko
dhaidashenko force-pushed the feature/build-external-with-keystore branch from 2ba6608 to 5bb65fc Compare July 16, 2026 10:59
@dhaidashenko
dhaidashenko marked this pull request as ready for review July 16, 2026 14:46
@dhaidashenko
dhaidashenko requested a review from a team as a code owner July 16, 2026 14:46
Copilot AI review requested due to automatic review settings July 16, 2026 14:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the “Build External Repositories” GitHub Actions workflow to use a shared ref-parsing script hosted in smartcontractkit/.github, and tightens the external build check by also bumping the chainlink-common/keystore module when building Chainlink Core.

Changes:

  • Switch build_external.yml to checkout and execute get-refs-from-pr-body.js from smartcontractkit/.github (sparse checkout into dot_github/).
  • Add an explicit go get for github.com/smartcontractkit/chainlink-common/keystore@${COMMON_SHA} when building /chainlink.
  • Remove the local .github/scripts/get-refs-from-pr-body.js script from this repo (now sourced externally).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/build_external.yml Uses shared script from smartcontractkit/.github and bumps chainlink-common/keystore in the Chainlink build step.
.github/scripts/get-refs-from-pr-body.js Removes the local script implementation (relocated to shared org .github repo).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +28 to +32
repository: smartcontractkit/.github
# TODO: pin to a commit SHA once the get-refs-from-pr-body.js PR is merged into smartcontractkit/.github.
ref: feature/get-ref-from-pr-body
persist-credentials: false
sparse-checkout: tools/scripts/get-refs-from-pr-body.js

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 64a24c5 Previous: 7d3ddf4 Ratio
BenchmarkKeystore_Sign/nop/in-process 758.2 ns/op 278.9 ns/op 2.72

This comment was automatically generated by workflow using github-action-benchmark.

@dhaidashenko
dhaidashenko requested a review from erikburt July 17, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants