Skip to content

Add corekeys package with CSA/OCRKeyBundle types#1793

Merged
cedric-cordenier merged 4 commits intomainfrom
corekeys
Jan 28, 2026
Merged

Add corekeys package with CSA/OCRKeyBundle types#1793
cedric-cordenier merged 4 commits intomainfrom
corekeys

Conversation

@cedric-cordenier
Copy link
Copy Markdown
Contributor

Requires

Supports

@cedric-cordenier cedric-cordenier requested review from a team as code owners January 23, 2026 13:30
Copilot AI review requested due to automatic review settings January 23, 2026 13:30
@github-actions
Copy link
Copy Markdown

👋 cedric-cordenier, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces the corekeys package to generate and handle CSA (Connection Signing Authority) and OCR (Off-Chain Reporting) key bundles compatible with the core node.

Changes:

  • Adds csa.go with GenerateEncryptedCSAKey and FromEncryptedCSAKey functions for CSA key management
  • Adds ocrkeybundle.go with GenerateEncryptedOCRKeyBundle and FromEncryptedOCRKeyBundle functions for OCR key bundle management
  • Includes comprehensive test coverage for both CSA and OCR key bundle round-trip operations, password validation, and invalid format handling

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
keystore/corekeys/csa.go Core implementation of CSA key generation, encryption, and decryption utilities
keystore/corekeys/csa_test.go Test coverage for CSA key operations including round-trip, wrong password, and invalid format scenarios
keystore/corekeys/ocrkeybundle.go Core implementation of OCR key bundle generation with support for offchain signing/encryption and onchain signing keys
keystore/corekeys/ocrkeybundle_test.go Test coverage for OCR key bundle operations including round-trip, password validation, invalid format, and invalid key type scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread keystore/corekeys/csa.go Outdated
Comment thread keystore/corekeys/csa.go Outdated
@cedric-cordenier cedric-cordenier mentioned this pull request Jan 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 23, 2026

✅ API Diff Results - No breaking changes


📄 View full apidiff report

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jan 28, 2026
Merged via the queue into main with commit 362e7e2 Jan 28, 2026
38 of 40 checks passed
@cedric-cordenier cedric-cordenier deleted the corekeys branch January 28, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants