Add corekeys package with CSA/OCRKeyBundle types#1793
Merged
cedric-cordenier merged 4 commits intomainfrom Jan 28, 2026
Merged
Conversation
|
👋 cedric-cordenier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces the corekeys package to generate and handle CSA (Connection Signing Authority) and OCR (Off-Chain Reporting) key bundles compatible with the core node.
Changes:
- Adds
csa.gowithGenerateEncryptedCSAKeyandFromEncryptedCSAKeyfunctions for CSA key management - Adds
ocrkeybundle.gowithGenerateEncryptedOCRKeyBundleandFromEncryptedOCRKeyBundlefunctions for OCR key bundle management - Includes comprehensive test coverage for both CSA and OCR key bundle round-trip operations, password validation, and invalid format handling
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| keystore/corekeys/csa.go | Core implementation of CSA key generation, encryption, and decryption utilities |
| keystore/corekeys/csa_test.go | Test coverage for CSA key operations including round-trip, wrong password, and invalid format scenarios |
| keystore/corekeys/ocrkeybundle.go | Core implementation of OCR key bundle generation with support for offchain signing/encryption and onchain signing keys |
| keystore/corekeys/ocrkeybundle_test.go | Test coverage for OCR key bundle operations including round-trip, password validation, invalid format, and invalid key type scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
✅ API Diff Results - No breaking changes |
55b8120 to
af03ae6
Compare
af03ae6 to
2ad9c86
Compare
0fa6d02 to
4d28de5
Compare
4d28de5 to
1488eae
Compare
jmank88
approved these changes
Jan 28, 2026
george-dorin
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports