Skip to content

Adding MaxGasPrice to GasConfig#1764

Closed
yashnevatia wants to merge 5 commits intomainfrom
PLEX-1522-MaxGasPrice
Closed

Adding MaxGasPrice to GasConfig#1764
yashnevatia wants to merge 5 commits intomainfrom
PLEX-1522-MaxGasPrice

Conversation

@yashnevatia
Copy link
Copy Markdown
Contributor

@yashnevatia yashnevatia commented Jan 9, 2026

Copilot AI review requested due to automatic review settings January 9, 2026 15:37
@yashnevatia yashnevatia requested review from a team as code owners January 9, 2026 15:37
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 9, 2026

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a MaxGasPrice field to the GasConfig struct in the EVM chain capabilities, allowing users to specify a maximum gas price in wei for transactions. The change is implemented in the generated protobuf code.

Changes:

  • Added optional MaxGasPrice field of type *pb.BigInt to GasConfig struct
  • Added getter method GetMaxGasPrice() for the new field
  • Updated protobuf version dependencies and raw descriptor data

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pkg/capabilities/v2/chain-capabilities/evm/client.pb.go Added MaxGasPrice field to GasConfig struct with corresponding getter method and protobuf descriptor updates
go.mod Added local replace directive for chainlink-protos dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod Outdated
Comment on lines +160 to +161

replace github.com/smartcontractkit/chainlink-protos/cre/go => /Users/yashvardhan/chainlink-protos/cre/go
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replace directive uses an absolute local file path specific to a user's machine (/Users/yashvardhan/...). This will break for other developers and CI/CD pipelines. Remove this replace directive before merging, or use a relative path if local development requires it.

Suggested change
replace github.com/smartcontractkit/chainlink-protos/cre/go => /Users/yashvardhan/chainlink-protos/cre/go

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 9, 2026

✅ API Diff Results - No breaking changes


📄 View full apidiff report

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Feb 13, 2026
@github-actions
Copy link
Copy Markdown

This PR has been automatically closed because it has been stale for > 30 days.
If you wish to continue working on this PR, please reopen it and make any necessary changes.

@github-actions github-actions Bot closed this Feb 21, 2026
@github-actions github-actions Bot deleted the PLEX-1522-MaxGasPrice branch February 21, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants