Stop using current date to testConversionFromDateTimeToMongoFormat#33
Open
BertrandF23 wants to merge 1 commit intomasterfrom
Open
Stop using current date to testConversionFromDateTimeToMongoFormat#33BertrandF23 wants to merge 1 commit intomasterfrom
BertrandF23 wants to merge 1 commit intomasterfrom
Conversation
…versionFromDateTimeToMongoFormat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using the current date to test convertFromMongoFormatToDateTime, and it happened that if the current milliseconds were under 100, the test was failing because of a bug in that function.
The test has been modified, using a provider, that allow to test it but also to show when it is failing. It seems to be due to a bug in MongoDb, so we should better update it instead of trying to fix it.