Add --non-interactive flag and improve TTY detection #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for non-interactive environments by: - Adding --non-interactive global flag (also STEP_NON_INTERACTIVE env var) - Checking for terminal availability before prompting for passwords - Returning helpful error messages when prompts fail in CI/systemd/Docker This change requires smallstep/cli-utils#210 which adds: - ui.CanPrompt() for TTY detection - errs.RequiredInputError for descriptive error messages Fixes #674 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
the
needs triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--non-interactiveglobal flag (alsoSTEP_NON_INTERACTIVEenv var)Problem
The CLI tries to open a TTY to prompt for user input even in non-interactive environments (systemd, GitHub Actions, Ansible, Docker), resulting in unhelpful errors like:
Solution
This PR adds TTY detection before prompting for passwords, returning a helpful error message:
Dependencies
This PR requires smallstep/cli-utils#210 to be merged and released first.
Test plan
Fixes #674
🤖 Generated with Claude Code