Open
Conversation
github-actions
bot
added
the
needs triage
|
|
Amend tests to no longer assert an error message upon active revocation and to instead validate the success on either revocation variant, reflecting previous changes. In theory the "Passive" boolean seems removable as it does not add any functionality besides being logged, but it was found some instances of it are still needed to block active revocation for SSH certificates. Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
tacerus
force-pushed
the
activerevocation
branch
from
5730d1b to
1e858f7
Compare
Author
|
@VonRehberg I'm not sure if you want to sign the CLA, but the first commit is authored by you, hence the bot is asking for it.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name of feature:
Allow for active revocation via HTTP API.
Pain or issue this feature alleviates:
Active revocation being rejected by the API.
Why is this important to the project (if not answered above):
Above.
Is there documentation on how to use this feature? If so, where?
Not any less documented than the existing HTTP API but will be reflected in Go docs.
In what environments or workflows is this feature supported?
n/a
In what environments or workflows is this feature explicitly NOT supported (if any)?
n/a
Supporting links/other PRs/issues:
This picks the commit from #2085 and adds another with the suggested improvements. As written in the commit message, the
Passiveboolean is kept as it still seems to be needed for preventing active revocation of SSH certificates.💔Thank you!