Checks if stack trace exists when logging errors#1
Open
toolbuilder wants to merge 1 commit intosmall-tech:mainfrom
Open
Checks if stack trace exists when logging errors#1toolbuilder wants to merge 1 commit intosmall-tech:mainfrom
toolbuilder wants to merge 1 commit intosmall-tech:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for writing this and esm-tape-runner. I use zora as a TAP producing test library instead of tape. Zora does not produce a stack trace when there is an error, so tap-monkey crashes. Here's my fix. I tested the pack file on my project. I also used rollup to create a CommonJS version of the project and tested with tape as the test runner. The tests were still zora, except one I converted to tape.
BTW, I've since found that pta is also an ES and CommonJS test runner that meets your requirements. Pta is the npm package name.