Open
Conversation
asraa
reviewed
Apr 29, 2022
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Some small feedback -- the log UUID can suffice to determine the shard and entry (see sigstore/rekor#587), so if you want, you can return the UUID as a single reference to the entry rather than log-index and shard (log ID)
WDYT?
Contributor
Author
|
hmm, i could have missed something but didn't see the UUID as part of the LogEntryAnon struct |
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
Contributor
|
Could you please merge or rebase? I'll take a re-review! I think from what I read - sharding is currently changing, but the log-index is indeed unique enough to determine the shard (log-index should be sum(inactive shards) + active shard), so you can compute where you are given the log ranges |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brandon Lum lumjjb@gmail.com