Adjust InjectorSurrogate module based on LUMETorchModel updates#20
Open
pluflou wants to merge 27 commits intoslaclab:injector-surrogatefrom
Open
Adjust InjectorSurrogate module based on LUMETorchModel updates#20pluflou wants to merge 27 commits intoslaclab:injector-surrogatefrom
pluflou wants to merge 27 commits intoslaclab:injector-surrogatefrom
Conversation
git-subtree-dir: subtrees git-subtree-split: d69a5fb55ec7b0c60254608f61595b288b6b481c
git-subtree-dir: subtrees/lcls_cu_injector_model git-subtree-split: d69a5fb55ec7b0c60254608f61595b288b6b481c
…lcls_cu_injector_model'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
InjectorSurrogateclass to align with changes inLUMETorchModel._cachedictionary (as inLUMETorchModel), removing the old_stateandupdate_statemethods. The model is initialized with default values (empty set call).self._cache = self.model._cachewas aliasing a private attribute).supported_variablesproperty to avoid mutating the wrapped model's metadata and to use a more explicit interface._tensor_to_numpyand_to_python_scalarto safely convert tensors to NumPy arrays and Python scalars.examples/injector_surrogate.ipynbto use the newoutput_beamkey instead ofbeam_output..submodulesdir because the naming is confusing (they are not submodules)subtrees/repo_namedirectory that clarifies what is in there