Conversation
shilorigins
approved these changes
Mar 30, 2026
Contributor
shilorigins
left a comment
There was a problem hiding this comment.
I definitely thought this issue was going to involve cutting out more stuff 😅
Contributor
|
Should we make an issue to cut out references from the frontend? |
Contributor
Author
I will make an issue now. |
287ef14 to
40ca591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes an unused query parameter from the
delete_pvendpoint. The archive parameter was unused by the backend, but is referenced in the frontend. Even if a value gets passed via the frontend, nothing happens with it.Motivation
Closes #33
Screenshots
After removing the query parameter I successfully deleted a PV using its ID. This shows that passing the removed query parameter will not cause problems with the frontend. It should still be removed from the frontend's

pvService.Pre-merge checklist