Skip to content

DEP: Remove Unused Query Parameter#51

Merged
zdomke merged 1 commit intomainfrom
zdomke/unused-q-param
Mar 30, 2026
Merged

DEP: Remove Unused Query Parameter#51
zdomke merged 1 commit intomainfrom
zdomke/unused-q-param

Conversation

@zdomke
Copy link
Copy Markdown
Contributor

@zdomke zdomke commented Mar 25, 2026

Description

Removes an unused query parameter from the delete_pv endpoint. The archive parameter was unused by the backend, but is referenced in the frontend. Even if a value gets passed via the frontend, nothing happens with it.

Motivation

Closes #33

Screenshots

After removing the query parameter I successfully deleted a PV using its ID. This shows that passing the removed query parameter will not cause problems with the frontend. It should still be removed from the frontend's pvService.
Screenshot 2026-03-25 at 11 43 32

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions

@zdomke zdomke requested a review from a team March 25, 2026 18:48
@zdomke zdomke self-assigned this Mar 25, 2026
Copy link
Copy Markdown
Contributor

@shilorigins shilorigins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely thought this issue was going to involve cutting out more stuff 😅

@shilorigins
Copy link
Copy Markdown
Contributor

Should we make an issue to cut out references from the frontend?

@zdomke
Copy link
Copy Markdown
Contributor Author

zdomke commented Mar 30, 2026

Should we make an issue to cut out references from the frontend?

I will make an issue now.
The way it's unused in the frontend means that it won't hurt for the references to stay for a bit. So the issue won't be urgent ¯\_(ツ)_/¯

@zdomke zdomke force-pushed the zdomke/unused-q-param branch from 287ef14 to 40ca591 Compare March 30, 2026 19:01
@zdomke zdomke merged commit 6572561 into main Mar 30, 2026
2 checks passed
@shilorigins shilorigins deleted the zdomke/unused-q-param branch March 30, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Unused Query Parameter in app/api/v1/pvs.py::delete_pv

2 participants