Merged
Conversation
2884a4b to
47319cc
Compare
shilorigins
reviewed
Mar 30, 2026
Contributor
shilorigins
left a comment
There was a problem hiding this comment.
Please fix the pre-commit warnings locally and then re-push so the job completes successfully.
47319cc to
23f58f6
Compare
zdomke
approved these changes
Mar 30, 2026
Contributor
zdomke
left a comment
There was a problem hiding this comment.
Looks good for me!
Tests pass locally, works locally, and code makes sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow duplicate readback_address and config_address while keeping setpoint_address unique.
Normalize blank optional addresses to NULL during PV creation/import.
Add bulk import pre-checks for duplicate/existing setpoints with batching to avoid Postgres parameter limits.
Add tests for blank optional addresses and duplicate readbacks.
Add migration to drop unique constraints on readback/config and keep non-unique indexes.
Motivation
CSV import of large datasets was failing with 500 errors due to uniqueness violations on optional address fields.
This change makes the uniqueness rules match the desired behavior (setpoint unique, readback/config allowed to repeat) and prevents hard DB errors during bulk import.
Where Has This Been Documented?
Code Comment
Screenshots
NA
Pre-merge checklist