Open
Conversation
YektaY
force-pushed
the
yektay/workflows
branch
from
f43c5d0 to
0567e65
Compare
YektaY
force-pushed
the
yektay/workflows
branch
from
a63b444 to
8a9e9f7
Compare
- Add build-and-deploy-dev, build-release, deploy-prod, deploy workflows - Add config.yaml and Dockerfile.prod for software factory onboarding
YektaY
force-pushed
the
yektay/workflows
branch
from
8a9e9f7 to
0234486
Compare
shilorigins
reviewed
Mar 25, 2026
Contributor
There was a problem hiding this comment.
This is a copy of config.yml: is this an unintended file, or is the contents incorrect?
shilorigins
reviewed
Mar 25, 2026
Comment on lines
+27
to
+28
| database_url: ${{ secrets.PROD_DATABASE_URL }} | ||
| redis_url: ${{ secrets.PROD_REDIS_URL }} |
Contributor
There was a problem hiding this comment.
I see DEV_{DATABASE,REDIS}_URL in this repo's environment secrets, and I see one secret each for the dev and prod environments. What are the environment secrets used for, and where are PROD_{DATABASE,REDIS}_URL defined?
zdomke
reviewed
Mar 27, 2026
Comment on lines
+15
to
+16
| COPY requirements.txt . | ||
| RUN pip install --no-cache-dir -r requirements.txt |
Contributor
There was a problem hiding this comment.
requirements.txt no longer exists on main after #52 swapped the project over to the project.toml
zdomke
reviewed
Mar 27, 2026
| # Copy application code | ||
| COPY app/ ./app/ | ||
| COPY alembic/ ./alembic/ | ||
| COPY alembic.ini . |
Contributor
There was a problem hiding this comment.
Suggested change
| COPY alembic.ini . | |
| COPY alembic.ini . | |
| COPY scripts/ ./scripts/ |
Should also copy over the key management scripts added in #48 so that we have the ability to create/deactivate keys in the container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass deployment secrets (database_url, redis_url, ghcr_token, ghcr_user) via client-payload to build-system-playbooks
Add manual "Deploy to Production" workflow (deploy-prod.yml) that triggers deploy-container-prod in build-system-playbooks
Prod deploy flow
Create a release → build-release.yml builds and pushes image
Go to Actions → "Deploy to Production" → enter release tag → Run
Triggers deploy-container-prod in build-system-playbooks → webhook → Deployment Controller → Ansible
Motivation
Set up CI/CD pipeline for the project
Where Has This Been Documented?
Screenshots
Pre-merge checklist